Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Jul 2015 10:02:29 +0000
From:      "kib (Konstantin Belousov)" <phabric-noreply@FreeBSD.org>
To:        freebsd-arm@freebsd.org
Subject:   [Differential] [Commented On] D3094: Fix KSTACK_PAGES issue
Message-ID:  <8b52536eef050c3cbf22722249062f45@localhost.localdomain>
In-Reply-To: <differential-rev-PHID-DREV-iyfes6yosmvf4z7iwnvz-req@FreeBSD.org>
References:  <differential-rev-PHID-DREV-iyfes6yosmvf4z7iwnvz-req@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
kib added a comment.

In https://reviews.freebsd.org/D3094#61493, @kib wrote:

>




> Note that it uncovers more serious issues.  E.g., the quick look at the amd64/amd64/stack_machdep.c clearly indicates that the use of KSTACK_PAGES there is bogus, probably curthread->td_kstack_pages is the right thing to use, but it is still not quite correct as well.  In fact, the if() should check whether the f_frame is inside the [curthread->td_kstack; curthread->td_kstack + PAGE_SIZE * curthread->td_kstack_pages).


https://reviews.freebsd.org/D3108
should fix the x86 issue, and allow you to drop these files from your change.


REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D3094

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: wma_semihalf.com, emaste, zbb, andrew, kib
Cc: kib, imp, andrew, freebsd-arm-list, emaste



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8b52536eef050c3cbf22722249062f45>