From owner-freebsd-testing@FreeBSD.ORG Sat Oct 19 20:49:42 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 15FBE450 for ; Sat, 19 Oct 2013 20:49:42 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pd0-x234.google.com (mail-pd0-x234.google.com [IPv6:2607:f8b0:400e:c02::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E10F22FE8 for ; Sat, 19 Oct 2013 20:49:41 +0000 (UTC) Received: by mail-pd0-f180.google.com with SMTP id p10so3717780pdj.39 for ; Sat, 19 Oct 2013 13:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=SGoQwmf7qlW9iB2hlBbnIdHVrr73e9Ht0Wc7tdKZLko=; b=RluOZ17NRu66rU0MB/XtpS8m1Ma6z7x39GaiXow/ZqXJh7jBVAYD7QkLQXQe01oZ+j fZyz5IisoEXYVZbY0/zm+2CnfdTFbCCwkVS7GOxaotYcJoQ8pfdv1WIu0E9w8YbO7wXm oACpw+0ic8dLuMeQdkUuDJ5cGgZu6b5fC1qoCk5/1Jg18GbframDKm6k1Zl5BQKONyYJ bND+waSPFurj9b6zGq8GIMqkqpfGf44oGl7P5hKolHdlNqBIm7/rx2Na3CjCXPsCtFq1 G1vQMhZfRO9WIOUCMBo1hHLD210ARS6IFf6ktwtTaCphLW5kIASeEIF6z2E6ysOf/s9C zHyA== X-Received: by 10.66.217.166 with SMTP id oz6mr10161009pac.22.1382215781512; Sat, 19 Oct 2013 13:49:41 -0700 (PDT) Received: from [10.3.73.48] (mobile-166-147-083-033.mycingular.net. [166.147.83.33]) by mx.google.com with ESMTPSA id wd6sm13883535pab.3.2013.10.19.13.49.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 19 Oct 2013 13:49:40 -0700 (PDT) References: Mime-Version: 1.0 (1.0) In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-Id: <6DC6C1E8-7AEF-439E-9250-D223A56EF432@gmail.com> X-Mailer: iPhone Mail (11A501) From: Garrett Cooper Subject: Re: Populating /usr/tests Date: Sat, 19 Oct 2013 13:49:36 -0700 To: Julio Merino Cc: "freebsd-testing@freebsd.org" , Rui Paulo , Simon Gerraty X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Oct 2013 20:49:42 -0000 You're missing a lot of code in etc/, some in Makefile.inc1, and other piece= s in share/mk as well with bsd.own.mk. Also, your approach with tests/Makefi= le is ok, but it doesn't partition well with prove.test.mk on my branch, etc= . Thanks, -Garrett PS No worries about the email addresses; I still use yanegomi, but mainly as= a spam catch address nowadays. > On Oct 19, 2013, at 8:49, Julio Merino wrote: >=20 > Hello, >=20 > [ CCing same interested parties as before ] >=20 > Here comes the next round of patches. This time the goal is to start > populating /usr/tests (which already exists) with the only test > program currently available in the tree: src/lib/libcrypt/tests/*. >=20 > With this boilerplate in place, adding new test programs to the base > system should be straightforward (which is the goal here!). I'll be > happy to provide a tutorial later if we agree to this scheme, similar > to the one we have for NetBSD (http://wiki.netbsd.org/tutorials/atf/), > detailing the procedure to add both atf-based and "old-style" test > programs. >=20 > The README file added in add-tests-hierarchy.diff and the tests.7 page > added in add-tests-7.diff might answer some of the questions you might > have. Not repasting their contents here. >=20 > As before, the new set of patches is in > http://portal.meroh.net/~jmmv/freebsd-testing/ . The series file in > it lists the order in which they need to be read/applied and each > patch has a header usable as the commit log. >=20 > I have successfully tested this both in amd64 and powerpc with update > and clean builds/installs. However, please review carefully. >=20 > Thoughts? >=20 > Thanks, >=20 > --=20 > Julio Merino / @jmmv > _______________________________________________ > freebsd-testing@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-testing > To unsubscribe, send any mail to "freebsd-testing-unsubscribe@freebsd.org"=