From owner-freebsd-bugs@FreeBSD.ORG Sat Aug 7 18:10:29 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2B4EC16A4CE for ; Sat, 7 Aug 2004 18:10:29 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1EA3743D39 for ; Sat, 7 Aug 2004 18:10:29 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i77IATtT057281 for ; Sat, 7 Aug 2004 18:10:29 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i77IASJm057280; Sat, 7 Aug 2004 18:10:28 GMT (envelope-from gnats) Date: Sat, 7 Aug 2004 18:10:28 GMT Message-Id: <200408071810.i77IASJm057280@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Tim Kientzle Subject: Re: bin/66492: cpio -o -Hustar creates broken timestamps X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Tim Kientzle List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Aug 2004 18:10:29 -0000 The following reply was made to PR bin/66492; it has been noted by GNATS. From: Tim Kientzle To: freebsd-gnats-submit@freebsd.org, naddy@freebsd.org, obrien@freebsd.org Cc: Subject: Re: bin/66492: cpio -o -Hustar creates broken timestamps Date: Sat, 07 Aug 2004 11:07:00 -0700 I've looked at this patch and it looks right to me. (And having spent much of the last year researching tar formats, I think my opinion might be worth something here. ;-) While we're in here, we should also fix to_oct to pad values with leading zeros (as POSIX requires) rather than leading spaces (as was common for pre-POSIX tar implementations). On the other hand, I doubt a lot of people use cpio to read/write tar archives, this is on the vendor branch, and it hasn't been touched in nearly seven years. David: I note that you did the last import of this and probably know more about vendor imports than anyone else around. Is this worth fixing? If you think so, let me know and I'll take care of it. Tim