Date: Sat, 23 Oct 2010 19:56:05 -0700 From: Garrett Cooper <gcooper@FreeBSD.org> To: Alexander Best <arundel@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: Re: fix pnpinfo on arch=amd64 Message-ID: <AANLkTinzn1r3qn3d7MoVhZPNOo6OHDfF-0KVrLN%2BC516@mail.gmail.com> In-Reply-To: <20101024002248.GA73346@freebsd.org> References: <20101024002248.GA73346@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0016364d2cbd547e8804935404dc Content-Type: text/plain; charset=ISO-8859-1 On Sat, Oct 23, 2010 at 5:22 PM, Alexander Best <arundel@freebsd.org> wrote: > this tiny patch will fix pnpinfo so it doesn't core dump (bus error) any > longer on arch=amd64. 1. I had to modify the Makefile to get it to work. 2. FWIW, I don't there's really much point in adding a check for only x86 architectures, if the tool is capable of more than that. 3. Might as well close the file descriptor after opening it. SIGBUS occurs because it doesn't have permission to write via outb. It's a shame that there isn't a more proper way to catch this SIGBUS fault minus adding a SIGBUS handler (but that might have other undesired side effects). Thanks, -Garrett --0016364d2cbd547e8804935404dc Content-Type: text/x-patch; charset=US-ASCII; name="pnpinfo-improvements.patch" Content-Disposition: attachment; filename="pnpinfo-improvements.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gfnbm9bi1 SW5kZXg6IGNvbnRyaWIvcG5waW5mby9wbnBpbmZvLmMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gY29udHJpYi9w bnBpbmZvL3BucGluZm8uYwkocmV2aXNpb24gMjE0MTY5KQorKysgY29udHJpYi9wbnBpbmZvL3Bu cGluZm8uYwkod29ya2luZyBjb3B5KQpAQCAtNTA2LDcgKzUwNiw3IEBACiAJfSBlbHNlIHsKIAkg ICAgLyogSGFuZGxlIGxhcmdlIHJlc291Y2UgZGF0YSB0eXBlcyAqLwogCSAgICB1X2NoYXIgYnVm WzJdOwotCSAgICBpZiAoIWdldF9yZXNvdXJjZV9pbmZvKChjaGFyICopYnVmLCAyKSkKKwkgICAg aWYgKCFnZXRfcmVzb3VyY2VfaW5mbyhidWYsIDIpKQogCQlicmVhazsKIAkgICAgbGFyZ2VfbGVu ID0gKGJ1ZlsxXSA8PCA4KSArIGJ1ZlswXTsKIApAQCAtNTg2LDEzICs1ODYsMTMgQEAKIGludAog bWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiB7CisgICAgaW50IGZkOwogICAgIGludCBudW1f cG5wX2RldnM7CiAKLSNpZmRlZiBfX2kzODZfXwogICAgIC8qIEhleSB3aGF0IGFib3V0IGEgaTM4 Nl9pb3BsKCkgY2FsbCA6KSAqLwotICAgIGlmIChvcGVuKCIvZGV2L2lvIiwgT19SRE9OTFkpIDwg MCkKLQllcnJ4KDEsICJjYW4ndCBnZXQgSS9PIHByaXZpbGVnZSIpOwotI2VuZGlmCisgICAgaWYg KChmZCA9IG9wZW4oIi9kZXYvaW8iLCBPX1JET05MWSkpIDwgMCkKKwllcnIoMSwgImNhbid0IGdl dCBJL08gcHJpdmlsZWdlcyIpOworICAgICh2b2lkKSBjbG9zZShmZCk7CiAKICAgICBwcmludGYo IkNoZWNraW5nIGZvciBQbHVnLW4tUGxheSBkZXZpY2VzLi4uXG4iKTsKIApJbmRleDogY29udHJp Yi9wbnBpbmZvL01ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNvbnRyaWIvcG5waW5mby9NYWtlZmls ZQkocmV2aXNpb24gMjE0MTY5KQorKysgY29udHJpYi9wbnBpbmZvL01ha2VmaWxlCSh3b3JraW5n IGNvcHkpCkBAIC0yLDYgKzIsNiBAQAogCiBQUk9HPQlwbnBpbmZvCiBNQU44PQlwbnBpbmZvLjgK LUNGTEFHUz0gLVdhbGwKK0NGTEFHUz0gLVdhbGwgLUkkey5DVVJESVJ9Ly4uLy4uL3N5cwogCiAu aW5jbHVkZSA8YnNkLnByb2cubWs+Cg== --0016364d2cbd547e8804935404dc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinzn1r3qn3d7MoVhZPNOo6OHDfF-0KVrLN%2BC516>