From owner-freebsd-current@FreeBSD.ORG Thu Sep 7 17:24:25 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B4D7F16A4DD; Thu, 7 Sep 2006 17:24:25 +0000 (UTC) (envelope-from davidch@broadcom.com) Received: from mms2.broadcom.com (mms2.broadcom.com [216.31.210.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id B505B43D46; Thu, 7 Sep 2006 17:24:24 +0000 (GMT) (envelope-from davidch@broadcom.com) Received: from 10.10.64.154 by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.2.0)); Thu, 07 Sep 2006 10:24:14 -0700 X-Server-Uuid: D9EB6F12-1469-4C1C-87A2-5E4C0D6F9D06 Received: by mail-irva-10.broadcom.com (Postfix, from userid 47) id F1B1D2B0; Thu, 7 Sep 2006 10:24:13 -0700 (PDT) Received: from mail-irva-8.broadcom.com (mail-irva-8 [10.10.64.221]) by mail-irva-10.broadcom.com (Postfix) with ESMTP id CBBCB2AF; Thu, 7 Sep 2006 10:24:13 -0700 (PDT) Received: from mail-irva-12.broadcom.com (mail-irva-12.broadcom.com [10.10.64.146]) by mail-irva-8.broadcom.com (MOS 3.7.5a-GA) with ESMTP id EEO88842; Thu, 7 Sep 2006 10:24:02 -0700 (PDT) Received: from NT-IRVA-0750.brcm.ad.broadcom.com (nt-irva-0750 [10.8.194.64]) by mail-irva-12.broadcom.com (Postfix) with ESMTP id A4A1369CA3; Thu, 7 Sep 2006 10:24:02 -0700 (PDT) X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Date: Thu, 7 Sep 2006 10:24:01 -0700 Message-ID: <09BFF2FA5EAB4A45B6655E151BBDD90301F128C8@NT-IRVA-0750.brcm.ad.broadcom.com> In-Reply-To: <450038BD.6010401@errno.com> Thread-Topic: bge(4) on BCM 5752 A02 panic due to media autoselect Thread-Index: AcbSkTGI+afBDAV+TIyn/Nr5oggIbgAEDiQg From: "David Christensen" To: "Sam Leffler" X-TMWD-Spam-Summary: SEV=1.1; DFV=A2006090705; IFV=2.0.6,4.0-7; RPD=4.00.0004; RPDID=303030312E30413031303230352E34353030353433372E303033342D412D; ENG=IBF; TS=20060907172415; CAT=NONE; CON=NONE; X-MMS-Spam-Filter-ID: A2006090705_4.00.0004_2.0.6,4.0-7 X-WSS-ID: 691E8A343885239316-01-01 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Cc: Oleg Bulyzhin , freebsd-current@freebsd.org, LI Xin , "Simon L. Nielsen" Subject: RE: bge(4) on BCM 5752 A02 panic due to media autoselect X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2006 17:24:25 -0000 > > Can you test the attached patch? I've simply removed the test > > altogether. > > The Linux driver doesn't perform this test and the fact=20 > that the test is > > performed after bge_reset() is called simply means we're=20 > checking the > > same > > information twice (i.e. did the NIC firmware load). Since=20 > the firmware > > handshake was successful we know the firmware loaded so the test is > > redundant. >=20 > This appears to fix problems I was seeing on a 5703 part (sorry David, > told you 5702 before): >=20 > bge0: mem=20 > 0xfaff0000-0xfaffffff > irq 11 at device 0.0 on pci2 >=20 There is actually a defect in the bge driver that will identify a 5702 as a 5703. This is caused by the fact that both the 5702 and the 5703 use the same ASIC IDs in hardware and the bge driver doesn't do any further checking to separate the two. My testing confirmed that the bge driver incorrectly=20 identified a 5702 as a 5703. > This is a Dell 600m. Prior to the patch I'd get the RX diagnostic > failed msg. dhclient would fetch a lease but I couldn't mount an nfs > volume (w/ UDP). With your patch things appear to work as before. That's good to know. If at least one of the other users who reported a=20 problem with my last patch can confirm that the issue is also fixed by=20 this change then I'll go ahead and commit it. Dave