From owner-cvs-all  Tue Feb  5 14:21: 6 2002
Delivered-To: cvs-all@freebsd.org
Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170])
	by hub.freebsd.org (Postfix) with ESMTP
	id C878237B420; Tue,  5 Feb 2002 14:20:39 -0800 (PST)
Received: (from uucp@localhost)
	by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g15MKdb34770;
	Tue, 5 Feb 2002 22:20:39 GMT
	(envelope-from mark@grondar.za)
Received: from greenpeace.grondar.org (greenpeace [192.168.42.2])
	by gratis.grondar.org (Postfix) with ESMTP
	id 309A0CE; Tue,  5 Feb 2002 22:19:43 +0000 (GMT)
Received: from grondar.za (localhost [127.0.0.1])
	by greenpeace.grondar.org (8.11.6/8.11.6) with ESMTP id g15MJhs32408;
	Tue, 5 Feb 2002 22:19:43 GMT
	(envelope-from mark@grondar.za)
Message-Id: <200202052219.g15MJhs32408@greenpeace.grondar.org>
To: "Andrey A. Chernov" <ache@nagual.pp.ru>
Cc: des@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libpam/modules/pam_unix pam_unix.c 
References: <20020205214703.GA8579@nagual.pp.ru> 
In-Reply-To: <20020205214703.GA8579@nagual.pp.ru> ; from "Andrey A. Chernov" <ache@nagual.pp.ru>  "Wed, 06 Feb 2002 00:47:03 +0300."
Date: Tue, 05 Feb 2002 22:19:38 +0000
From: Mark Murray <mark@grondar.za>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> On Tue, Feb 05, 2002 at 23:59:08 +0300, Andrey A. Chernov wrote:
> 
> > It is OK at this point, but broken _after_ PAM called.
> > Lets imagine srandom(33) produce this hypotetical sequence for random() 
> > calls:
> 
> To see the bug, run following test application with "call_pam" set to 1 
> and 0

The bug is doing userland stuff before the authentication IMO.

> #include <stdlib.h>
> 
> int call_pam = 0;
> 
> main()
> {
> srandom(33);
> random();
> random();
> if (call_pam) libpam_steals_N_randoms();
> printf("%d\n", random());
> }

Should look like

#include <stdlib.h>

int call_pam = 0;

main()
{
if (call_pam) libpam_steals_N_randoms();
srandom(33);
random();
random();
printf("%d\n", random());
}

M
-- 
o       Mark Murray
\_      FreeBSD Services Limited
O.\_    Warning: this .sig is umop ap!sdn

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message