From owner-cvs-src@FreeBSD.ORG Fri Dec 30 10:59:19 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C2AE16A41F; Fri, 30 Dec 2005 10:59:19 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from www.ebusiness-leidinger.de (jojo.ms-net.de [84.16.236.246]) by mx1.FreeBSD.org (Postfix) with ESMTP id D46F543D4C; Fri, 30 Dec 2005 10:59:18 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from Andro-Beta.Leidinger.net (p54A5CF88.dip.t-dialin.net [84.165.207.136]) (authenticated bits=0) by www.ebusiness-leidinger.de (8.13.1/8.13.1) with ESMTP id jBUAuIL1037521; Fri, 30 Dec 2005 11:56:20 +0100 (CET) (envelope-from netchild@FreeBSD.org) Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) by Andro-Beta.Leidinger.net (8.13.3/8.13.3) with ESMTP id jBUAxD0o004343; Fri, 30 Dec 2005 11:59:13 +0100 (CET) (envelope-from netchild@FreeBSD.org) Date: Fri, 30 Dec 2005 11:59:13 +0100 From: Alexander Leidinger To: Nate Lawson Message-ID: <20051230115913.243e3e21@Magellan.Leidinger.net> In-Reply-To: <43B4FDD5.1060000@root.org> References: <20051229183552.205C316A432@hub.freebsd.org> <43B4385D.9030206@root.org> <20051229222645.05311b1f@Magellan.Leidinger.net> <43B4FDD5.1060000@root.org> Organization: FreeBSD X-Mailer: Sylpheed-Claws 1.9.100 (GTK+ 2.8.9; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new Cc: mux@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ums.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2005 10:59:19 -0000 On Fri, 30 Dec 2005 01:28:53 -0800 Nate Lawson wrote: > >>> #define UMS_BUT(i) ((i) < 3 ? (((i) + 2) % 3) : (i)) > I meant that this maps 0:2, 1:0, 2:1, 3:3, 4:4, ... Or in other words, > it only operates on 2-bit values (0-3). I don't know if that's an issue > or not, I just was wondering if that also needed to be expanded. NetBSD has: #define UMS_BUT(i) ((i) == 1 || (i) == 2 ? 3 - (i) : i) So this maps 0:0, 1:2, 2:1, 3:3, 4:4, ... so it's completely different below 3 and the same for the rest. So for the new buttons 8 to 31 it doesn't make a difference. Since it also wasn't changed in the MAX_BUTTONS commit, I didn't merged it. I think the change was introduced in the uhidev commit, but I didn't checked this. Maxime (CCed) is working on merging the uhidev stuff, maybe he knows for sure. Bye, Alexander. -- Weird enough for government work. http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7