Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 11 Jan 2011 19:17:13 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r217277 - stable/8/sys/amd64/amd64
Message-ID:  <201101111917.p0BJHDR3031998@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dim
Date: Tue Jan 11 19:17:13 2011
New Revision: 217277
URL: http://svn.freebsd.org/changeset/base/217277

Log:
  MFC r215801:
  
  Change ambiguous (or invalid, depending on how strict you want to be :)
  assembly instruction "movw %rcx,2(%rax)" to "movw %cx,2(%rax)", since
  the intent was to move 16 bits of data, in this case.
  
  Found by:	clang
  Reviewed by:	kib

Modified:
  stable/8/sys/amd64/amd64/cpu_switch.S
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)

Modified: stable/8/sys/amd64/amd64/cpu_switch.S
==============================================================================
--- stable/8/sys/amd64/amd64/cpu_switch.S	Tue Jan 11 19:13:29 2011	(r217276)
+++ stable/8/sys/amd64/amd64/cpu_switch.S	Tue Jan 11 19:17:13 2011	(r217277)
@@ -276,7 +276,7 @@ load_dr:
 do_tss:	movq	%rdx,PCPU(TSSP)
 	movq	%rdx,%rcx
 	movq	PCPU(TSS),%rax
-	movw	%rcx,2(%rax)
+	movw	%cx,2(%rax)
 	shrq	$16,%rcx
 	movb	%cl,4(%rax)
 	shrq	$8,%rcx



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101111917.p0BJHDR3031998>