From owner-cvs-src@FreeBSD.ORG Thu Mar 27 19:55:49 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A3811065673; Thu, 27 Mar 2008 19:55:49 +0000 (UTC) (envelope-from jb@what-creek.com) Received: from what-creek.com (what-creek.com [66.111.37.70]) by mx1.freebsd.org (Postfix) with ESMTP id 0431B8FC16; Thu, 27 Mar 2008 19:55:48 +0000 (UTC) (envelope-from jb@what-creek.com) Received: by what-creek.com (Postfix, from userid 102) id 0782973304; Thu, 27 Mar 2008 19:37:33 +0000 (GMT) Date: Thu, 27 Mar 2008 19:37:32 +0000 From: John Birrell To: Robert Watson Message-ID: <20080327193732.GA30621@what-creek.com> References: <200803270503.m2R53Qr7053473@repoman.freebsd.org> <20080327072329.U34007@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080327072329.U34007@fledge.watson.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org, John Birrell , cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/include param.h src/sys/arm/include param.h src/sys/i386/include param.h src/sys/ia64/include param.h src/sys/powerpc/include param.h src/sys/sparc64/include param.h src/sys/sun4v/include param.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2008 19:55:49 -0000 On Thu, Mar 27, 2008 at 07:52:42AM +0000, Robert Watson wrote: > Hmm. I think this probably is the right thing, but we'll need to be very > careful to watch for people defining foo[MAXCPU] in globally visible data > structures in the kernel in such a way that entries for the non-current CPU > are referenced by any modules. A casual glance suggests that, right now, > this is not generally an issue, but something to watch out for, since we do > use MAXCPU to size a number of kernel data structures. I should have added to the commit message: Suggested by: jhb -- John Birrell