From owner-svn-src-all@FreeBSD.ORG Mon Oct 7 08:09:57 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E6494E89; Mon, 7 Oct 2013 08:09:57 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6AB3C2C17; Mon, 7 Oct 2013 08:09:57 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id r9789tqu013260; Mon, 7 Oct 2013 12:09:55 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id r9789tEF013259; Mon, 7 Oct 2013 12:09:55 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 7 Oct 2013 12:09:55 +0400 From: Gleb Smirnoff To: "Alexander V. Chernikov" Subject: Re: svn commit: r256066 - head/sys/dev/virtio/network Message-ID: <20131007080955.GI8860@FreeBSD.org> References: <201310051807.r95I7P0M048589@svn.freebsd.org> <525080A6.6020505@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <525080A6.6020505@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, Bryan Venteicher , svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Oct 2013 08:09:58 -0000 On Sun, Oct 06, 2013 at 01:12:06AM +0400, Alexander V. Chernikov wrote: A> On 05.10.2013 22:07, Bryan Venteicher wrote: A> > Author: bryanv A> > Date: Sat Oct 5 18:07:24 2013 A> > New Revision: 256066 A> > URL: http://svnweb.freebsd.org/changeset/base/256066 A> > A> > Log: A> > Do not hold the vtnet Rx queue lock when calling up into the stack A> Do you measure performance penalty for this? A> > A> > This matches other similar drivers and avoids various LOR warnings. A> We're currently trying to eliminate such things in other drivers like A> ixgbe, maybe there can be some other way to eliminate possible LORs? True, but we don't have time to do that before 10.0-RELEASE. So, from upcoming release perspective, Bryan change is correct fix. -- Totus tuus, Glebius.