From owner-freebsd-current@FreeBSD.ORG Wed Oct 10 20:21:27 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BEA0F16A421 for ; Wed, 10 Oct 2007 20:21:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 22F8D13C467 for ; Wed, 10 Oct 2007 20:21:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 213848293-1834499 for multiple; Wed, 10 Oct 2007 16:19:30 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l9AKL3aZ017064; Wed, 10 Oct 2007 16:21:24 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-current@freebsd.org Date: Wed, 10 Oct 2007 16:15:48 -0400 User-Agent: KMail/1.9.6 References: <20070912172752.GA13960@dan.emsphone.com> In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200710101615.48760.jhb@freebsd.org> Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 10 Oct 2007 16:21:24 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4523/Wed Oct 10 14:30:26 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Ivan Voras Subject: Re: Panic in arpresolve->rt_check? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2007 20:21:27 -0000 On Wednesday 12 September 2007 02:50:37 pm Ivan Voras wrote: > Dan Nelson wrote: > > > The same panic was also reported for 6.2 via PR 107865 and PR 112490. > > 112490 included a workaround patch (I haven't tried it; just found it). > > The proposed patch in kern/112490 looks trivial but someone who knows > more about net locking should check it out. Unfortunately it lacks > context and I don't know the code in question to apply it safely on a > production machine :( I also get panics with what appears to be a double free of rt_gwroute in rtexpunge(), so I think while this PR may help some with figuring out the problem, I'm not sure it solves the root bug. Hmm, possibly try this patch: Index: route.c =================================================================== RCS file: /usr/cvs/src/sys/net/route.c,v retrieving revision 1.120 diff -c -r1.120 route.c *** route.c 11 Jun 2007 12:19:34 -0000 1.120 --- route.c 10 Oct 2007 20:12:54 -0000 *************** *** 1314,1319 **** --- 1314,1321 ---- return (ENETUNREACH); } RT_LOCK(rt0); + if (rt0->rt_gwroute != NULL) + RTFREE(rt0->rt_gwroute); rt0->rt_gwroute = rt; if (rt == NULL) { RT_UNLOCK(rt0); -- John Baldwin