From owner-svn-src-all@FreeBSD.ORG Mon Oct 21 22:55:56 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D0360E2F; Mon, 21 Oct 2013 22:55:56 +0000 (UTC) (envelope-from sbruno@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id BCA202D20; Mon, 21 Oct 2013 22:55:56 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r9LMtuQ4014525; Mon, 21 Oct 2013 22:55:56 GMT (envelope-from sbruno@svn.freebsd.org) Received: (from sbruno@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r9LMtuSX014524; Mon, 21 Oct 2013 22:55:56 GMT (envelope-from sbruno@svn.freebsd.org) Message-Id: <201310212255.r9LMtuSX014524@svn.freebsd.org> From: Sean Bruno Date: Mon, 21 Oct 2013 22:55:56 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r256866 - head/contrib/gcclibs/libssp X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Oct 2013 22:55:56 -0000 Author: sbruno Date: Mon Oct 21 22:55:56 2013 New Revision: 256866 URL: http://svnweb.freebsd.org/changeset/base/256866 Log: Resolve clang warning about a use of syslog. By using a proper enforcement of string format in a call so syslog /usr/src/gnu/lib/libssp/../../../contrib/gcclibs/libssp/ssp.c:137:23: warning: format string is not a string literal (potentially insecure) [-Wformat-security] syslog (LOG_CRIT, msg1); ^~~~ Reviewed by: dim@ Modified: head/contrib/gcclibs/libssp/ssp.c Modified: head/contrib/gcclibs/libssp/ssp.c ============================================================================== --- head/contrib/gcclibs/libssp/ssp.c Mon Oct 21 22:43:38 2013 (r256865) +++ head/contrib/gcclibs/libssp/ssp.c Mon Oct 21 22:55:56 2013 (r256866) @@ -128,7 +128,7 @@ fail (const char *msg1, size_t msg1len, #ifdef HAVE_SYSLOG_H /* Only send the error to syslog if there was no tty available. */ else - syslog (LOG_CRIT, msg3); + syslog (LOG_CRIT, "%s", msg3); #endif /* HAVE_SYSLOG_H */ /* Try very hard to exit. Note that signals may be blocked preventing