From owner-freebsd-gnome@FreeBSD.ORG Wed Sep 24 17:00:11 2008 Return-Path: Delivered-To: gnome@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5085106569B for ; Wed, 24 Sep 2008 17:00:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C56678FC28 for ; Wed, 24 Sep 2008 17:00:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m8OH0BEc036352 for ; Wed, 24 Sep 2008 17:00:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m8OH0BIM036351; Wed, 24 Sep 2008 17:00:11 GMT (envelope-from gnats) Date: Wed, 24 Sep 2008 17:00:11 GMT Message-Id: <200809241700.m8OH0BIM036351@freefall.freebsd.org> To: gnome@FreeBSD.org From: "Jeremy Messenger" Cc: Subject: Re: ports/127297: Redefinition warnings in print/freetype2 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jeremy Messenger List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Sep 2008 17:00:11 -0000 The following reply was made to PR ports/127297; it has been noted by GNATS. From: "Jeremy Messenger" To: bug-followup@freebsd.org, koitsu@freebsd.org Cc: Subject: Re: ports/127297: Redefinition warnings in print/freetype2 Date: Wed, 24 Sep 2008 11:58:26 -0500 > The pre-patch section comments out #define > TT_CONFIG_OPTION_BYTECODE_INTERPRETER in > include/freetype/config/ftoption.h (when WITHOUT_TTF_BYTECODE_ENABLED is > not defined by the user), but then earlier in the Makefile, it > re-enables it: I am not seeing any bug. When the WITHOUT_TTF_BYTECODE_ENABLED is not defined then the TT_CONFIG_OPTION_BYTECODE_INTERPRETER will be enable, which is a correct behavior. Unless I am blind? -------------------------------------------------------- # pwd /usr/ports/print/freetype2 # make extract # grep TT_CONFIG_OPTION_BYTECODE_INTERPRETER work/freetype-2.3.7/include/freetype/config/ftoption.h /* Define TT_CONFIG_OPTION_BYTECODE_INTERPRETER if you want to compile */ /* #define TT_CONFIG_OPTION_BYTECODE_INTERPRETER */ <-- disable /* define TT_CONFIG_OPTION_BYTECODE_INTERPRETER; with other words, */ /* either define TT_CONFIG_OPTION_BYTECODE_INTERPRETER or */ #ifdef TT_CONFIG_OPTION_BYTECODE_INTERPRETER # make patch # grep TT_CONFIG_OPTION_BYTECODE_INTERPRETER work/freetype-2.3.7/include/freetype/config/ftoption.h /* Define TT_CONFIG_OPTION_BYTECODE_INTERPRETER if you want to compile */ #define TT_CONFIG_OPTION_BYTECODE_INTERPRETER <-- enable /* define TT_CONFIG_OPTION_BYTECODE_INTERPRETER; with other words, */ /* either define TT_CONFIG_OPTION_BYTECODE_INTERPRETER or */ #ifdef TT_CONFIG_OPTION_BYTECODE_INTERPRETER -------------------------------------------------------- There is no problem. As for the redefine warning, I think it's harmless since it's still enable with no change as it's merely enable again. Cheers, Mezz -- mezz7@cox.net - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org