From owner-svn-src-user@FreeBSD.ORG  Sat Feb 16 17:47:48 2013
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 2F715906;
 Sat, 16 Feb 2013 17:47:48 +0000 (UTC)
 (envelope-from crees@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 0CA646CF;
 Sat, 16 Feb 2013 17:47:48 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id r1GHllUH076809;
 Sat, 16 Feb 2013 17:47:47 GMT (envelope-from crees@svn.freebsd.org)
Received: (from crees@localhost)
 by svn.freebsd.org (8.14.5/8.14.5/Submit) id r1GHll7b076807;
 Sat, 16 Feb 2013 17:47:47 GMT (envelope-from crees@svn.freebsd.org)
Message-Id: <201302161747.r1GHll7b076807@svn.freebsd.org>
From: Chris Rees <crees@FreeBSD.org>
Date: Sat, 16 Feb 2013 17:47:47 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-user@freebsd.org
Subject: svn commit: r246878 - user/crees/rclint
X-SVN-Group: user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Feb 2013 17:47:48 -0000

Author: crees (ports committer)
Date: Sat Feb 16 17:47:47 2013
New Revision: 246878
URL: http://svnweb.freebsd.org/changeset/base/246878

Log:
  Check properly for quoted variables when deciding on pointlessness
  
  Submitted by:	bdrewery

Modified:
  user/crees/rclint/Makefile
  user/crees/rclint/rclint.py

Modified: user/crees/rclint/Makefile
==============================================================================
--- user/crees/rclint/Makefile	Sat Feb 16 15:11:40 2013	(r246877)
+++ user/crees/rclint/Makefile	Sat Feb 16 17:47:47 2013	(r246878)
@@ -21,6 +21,9 @@ FILES=	${SCRIPT} errors.en problems.en
 
 .PHONY: majorbump minorbump microbump release
 
+all:
+	@${ECHO} majorbump, minorbump, microbump and tarball are valid targets
+
 majorbump:
 	M=$$(expr ${VERSION_MAJOR} + 1); \
 	${SED} -i '' -e "s,^\(MAJOR = \).*,\1$$M," ${SCRIPT}

Modified: user/crees/rclint/rclint.py
==============================================================================
--- user/crees/rclint/rclint.py	Sat Feb 16 15:11:40 2013	(r246877)
+++ user/crees/rclint/rclint.py	Sat Feb 16 17:47:47 2013	(r246878)
@@ -28,7 +28,7 @@ __version__ = '$FreeBSD$'
 
 MAJOR = 0
 MINOR = 0
-MICRO = 3
+MICRO = 4
 
 DATADIR = '.'
 
@@ -108,10 +108,11 @@ class Statement:
             return False
 
     def pointless_quoted(self):
-        if self.quoted():
-            for char in self.value:
-                if char in ' \t|&;<>()$`\\\"\'':
-                    return False
+        if not self.quoted():
+            return False
+        for char in self.value:
+            if char in ' \t|&;<>()$`\\\"\'':
+                return False
         return True
 
     def get_value(self):