From owner-svn-src-head@FreeBSD.ORG Sun Oct 13 15:18:26 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3BC0492F; Sun, 13 Oct 2013 15:18:26 +0000 (UTC) (envelope-from mark@grondar.org) Received: from gromit.grondar.org (grandfather.grondar.org [IPv6:2a01:348:0:15:5d59:5c20:0:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id F23F4278C; Sun, 13 Oct 2013 15:18:25 +0000 (UTC) Received: from graveyard.grondar.org ([88.96.155.33] helo=gronkulator.grondar.org) by gromit.grondar.org with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.80.1 (FreeBSD)) (envelope-from ) id 1VVNR1-000KUV-0F; Sun, 13 Oct 2013 16:18:24 +0100 Subject: Re: svn commit: r256377 - in head: etc/defaults etc/rc.d share/examples/kld/random_adaptor share/man/man4 sys/boot/forth sys/conf sys/dev/glxsb sys/dev/hifn sys/dev/random sys/dev/rndtest sys/dev/safe ... Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Content-Type: multipart/signed; boundary="Apple-Mail=_12CC3E7C-9487-46CC-8C67-9C690235F253"; protocol="application/pgp-signature"; micalg=pgp-sha512 From: Mark R V Murray In-Reply-To: <20131013151359.GR41229@kib.kiev.ua> Date: Sun, 13 Oct 2013 16:18:22 +0100 Message-Id: <812C1C64-75B0-4FE9-8FCD-B25A484448C6@grondar.org> References: <201310121257.r9CCvvjO006546@svn.freebsd.org> <20131013074825.GO41229@kib.kiev.ua> <3B77143C-7D82-4E62-9974-BC2C6846893F@grondar.org> <20131013151359.GR41229@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1510) X-SA-Score: -2.2 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Mark Murray X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Oct 2013 15:18:26 -0000 --Apple-Mail=_12CC3E7C-9487-46CC-8C67-9C690235F253 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 13 Oct 2013, at 16:13, Konstantin Belousov wrote: > Surely this works, thank you. The rwfile.c content probably should be > taken under the #ifdef RANDOM_RWFILE. OK - thanks for the feedback! > But I do not see much use for the randomdev_read_file() and > randomdev_write_file() functions. It would be better to directly code > the VFS calls in the random_harvestq_cache(). For one thing, it would > eliminate unneccessary close and open of the entropy file. There is some uncertainty about the future of that code, so I want to keep it that way for now. Writing files from the kernel is making so@ very uncomfortable, and there is too much scope for error there. We'll settle it down properly in 11.*. M -- Mark R V Murray --Apple-Mail=_12CC3E7C-9487-46CC-8C67-9C690235F253 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) Comment: GPGTools - http://gpgtools.org iQCVAwUBUlq5vt58vKOKE6LNAQomJQQAo8/Uc/cgHY5UY8V9KyZhlFrO5p6VMsbI 37TszhBH72SzjQHQC0tkbS1ekCXWwkqxjMTrOqgdayrF3PGJIan8kKKZ+h96KV0k jVeBqVpX8R+BhaG7Af1SjhXQDIBRdjl0+LTG07VCkcPEJKxXCl5UXtzKW76WFWWf +B0tUYaRBHc= =Gn/+ -----END PGP SIGNATURE----- --Apple-Mail=_12CC3E7C-9487-46CC-8C67-9C690235F253--