Date: Mon, 21 Jul 2008 19:10:03 GMT From: Jonathan Hanna <jhanna@shaw.ca> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/125683: ports/japanese/edict does not work on 7.0/i386, 7.0/amd64 Message-ID: <200807211910.m6LJA3L8076263@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/125683; it has been noted by GNATS. From: Jonathan Hanna <jhanna@shaw.ca> To: bug-followup@FreeBSD.org Cc: Kazunori_Fujiwara <fujiwara@wide.ad.jp> Subject: Re: ports/125683: ports/japanese/edict does not work on 7.0/i386, 7.0/amd64 Date: Mon, 21 Jul 2008 11:09:00 -0700 Edwin Groothuis wrote: > Maintainer of japanese/edict, > > Please note that PR ports/125683 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/125683 > It looks like in: files/patch-64bit: --- xjdxgen.c 2008-06-19 17:51:17.000000000 +0900 +++ xjdxgen.c- 2008-06-19 17:50:47.000000000 +0900 @@ -154,7 +154,7 @@ db[diclen] = 10; db[0] = 10; printf("Dictionary size: %ld bytes.\n",dbyte); - indlen = (diclen * 3)/4; + indlen = (diclen * 3*(sizeof(void *)/4))/4; jindex = (unsigned long *)malloc(indlen); if(jindex == NULL) { that indlen = (diclen * 3*(sizeof(long)/4))/4; is better, as the bounds checks in the code read: if (indptr > indlen/sizeof(long)) ... Otherwise looks good. I would be happy if some else took maintainership too...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200807211910.m6LJA3L8076263>