From owner-freebsd-bugs Fri Apr 6 7:12:40 2001 Delivered-To: freebsd-bugs@freebsd.org Received: from mail.yadt.co.uk (yadt.demon.co.uk [158.152.4.134]) by hub.freebsd.org (Postfix) with SMTP id D538A37B440 for ; Fri, 6 Apr 2001 07:12:29 -0700 (PDT) (envelope-from davidt@yadt.co.uk) Received: (qmail 13522 invoked from network); 6 Apr 2001 14:12:22 -0000 Received: from gattaca.local.yadt.co.uk (HELO mail.gattaca.yadt.co.uk) (qmailr@10.0.0.2) by xfiles.yadt.co.uk with SMTP; 6 Apr 2001 14:12:22 -0000 Received: (qmail 1207 invoked by uid 1000); 6 Apr 2001 14:12:21 -0000 Date: Fri, 6 Apr 2001 15:12:21 +0100 From: David Taylor To: freebsd-bugs@FreeBSD.ORG Subject: Re: kern/26317: /modules not created by make installkernel Message-ID: <20010406151221.A888@gattaca.yadt.co.uk> Mail-Followup-To: freebsd-bugs@FreeBSD.ORG References: <20010406145604.A447@ringworld.oblivion.bg> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="yrj/dFKFPuw6o+aM" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from bde@zeta.org.au on Fri, Apr 06, 2001 at 23:39:59 +1000 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org --yrj/dFKFPuw6o+aM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, 06 Apr 2001, Bruce Evans wrote: > >=20 > > So, basically, are you saying that this is not a problem and this PR sh= ould > > be closed, or do you think the installkernel target should at least make > > an attempt at doing the right thing in case of a user mess-up, and just > > mkdir ${DESTDIR}/modules? >=20 > I would close it. >=20 > Using mkdir would be wrong since it might get the directory ownership or > permissions wrong. >=20 It should at least bomb out with an error message, instead of pretending it succesfully installed your kernel and modules, even though what it _actually_ did was install one module as '/modules'... --=20 David Taylor davidt@yadt.co.uk --yrj/dFKFPuw6o+aM Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE6zc7FfIqKXSsJ/xERAsQjAJ4w2gV/j+fqaZE4ufDd3zwJFRKAmQCeO2rH +X3eTqOGqyfLDaI+IiGE7Q8= =TwV5 -----END PGP SIGNATURE----- --yrj/dFKFPuw6o+aM-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message