Date: Sun, 01 Feb 2004 19:26:21 +0100 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Lukas Ertl <l.ertl@univie.ac.at> Cc: freebsd-geom@freebsd.org Subject: Re: Panic in g_disk_done() with atacontrol detach Message-ID: <30784.1075659981@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 01 Feb 2004 19:12:57 %2B0100." <20040201190653.M613@korben.in.tern>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20040201190653.M613@korben.in.tern>, Lukas Ertl writes: >Hi, > >I can provoke a panic when doing "atacontrol detach 1" if there's an >active filesystem on the disk being detached. The panic happens in >g_disk_done() at: > > devstat_end_transaction_bio(dp->d_devstat, bp2); > >The problem obviously is that ad_detach() calls disk_destroy() which nulls >out the softc, and in g_disk_done() this softc is referenced again. > >The question is: is this an unsupported operation in the sense of "don't >do that"? If yes, then "atacontrol detach" should probably refuse to do >the actual detach when there are I/O requests running, this would prevent >a lot of foot shooting. No, this should work. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?30784.1075659981>