From owner-svn-src-head@freebsd.org  Wed Jun 14 15:52:16 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00789B953A4;
 Wed, 14 Jun 2017 15:52:16 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B914D6A63F;
 Wed, 14 Jun 2017 15:52:15 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v5EFq53W062077;
 Wed, 14 Jun 2017 08:52:05 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v5EFq5rJ062076;
 Wed, 14 Jun 2017 08:52:05 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201706141552.v5EFq5rJ062076@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r319905 - in head/sys: kern sys
In-Reply-To: <d7318b86-c168-1bbb-d795-071abef07926@rice.edu>
To: Alan Cox <alc@rice.edu>
Date: Wed, 14 Jun 2017 08:52:05 -0700 (PDT)
CC: Hans Petter Selasky <hps@selasky.org>, Alan Cox <alc@freebsd.org>,
 src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Jun 2017 15:52:16 -0000

[ Charset UTF-8 unsupported, converting... ]
> On 06/14/2017 06:04, Hans Petter Selasky wrote:
> > On 06/13/17 19:49, Alan Cox wrote:
> >> +#define    bitcount64(x)    __bitcount64((uint64_t)(x))
> >
> > bitcount64() is already defined by sys/libkern.h - use that? 
> 
> This snippet appears in code that is only used when compiling this file
> as a user-space application for testing.  Attempting to use
> sys/libkern.h in the user-space compilation provoked warnings.

Could we please add a comment to this define indicating this?

-- 
Rod Grimes                                                 rgrimes@freebsd.org