From nobody Tue May 23 10:36:50 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QQW315Rczz4CJjv for ; Tue, 23 May 2023 10:37:01 +0000 (UTC) (envelope-from jamie@catflap.org) Received: from donotpassgo.dyslexicfish.net (donotpassgo.dyslexicfish.net [IPv6:2001:19f0:7400:8808:123::1]) by mx1.freebsd.org (Postfix) with ESMTP id 4QQW312mq1z3JTx for ; Tue, 23 May 2023 10:37:01 +0000 (UTC) (envelope-from jamie@catflap.org) Authentication-Results: mx1.freebsd.org; none X-Catflap-Envelope-From: Received: from donotpassgo.dyslexicfish.net (donotpassgo.dyslexicfish.net [209.250.224.51]) by donotpassgo.dyslexicfish.net (8.14.5/8.14.5) with ESMTP id 34NAaov1069903; Tue, 23 May 2023 11:36:51 +0100 (BST) (envelope-from jamie@donotpassgo.dyslexicfish.net) Received: (from jamie@localhost) by donotpassgo.dyslexicfish.net (8.14.5/8.14.5/Submit) id 34NAaoKu069902; Tue, 23 May 2023 11:36:50 +0100 (BST) (envelope-from jamie) From: Jamie Landeg-Jones Message-Id: <202305231036.34NAaoKu069902@donotpassgo.dyslexicfish.net> Date: Tue, 23 May 2023 11:36:50 +0100 Organization: Dyslexic Fish To: yaneurabeya@gmail.com, jamie@catflap.org, freebsd-current@freebsd.org, d@delphij.net Subject: Re: MOTD is not created correctly (since 2022/02/18) References: <202305230318.34N3IOaX056503@donotpassgo.dyslexicfish.net> <06086c98-8d54-49b3-d292-d26eb247fcd6@delphij.net> In-Reply-To: <06086c98-8d54-49b3-d292-d26eb247fcd6@delphij.net> User-Agent: Heirloom mailx 12.4 7/29/08 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.7 (donotpassgo.dyslexicfish.net [209.250.224.51]); Tue, 23 May 2023 11:36:51 +0100 (BST) X-Rspamd-Queue-Id: 4QQW312mq1z3JTx X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:20473, ipnet:2001:19f0:7400::/38, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Xin Li wrote: > Maybe https://reviews.freebsd.org/D40225 ? > > (Nice find by the way! I always feel that something was not right but > haven't looked close enough.) Thanks! What is the best way to report things like this in the future? I'm happy to create a phabricator report, Enji suggested a PR, and previously, Warner said he's happy to accept github pull requests for small changes. Now, I admit I've not yet looked at how to do github pull requests, so that omission is entirely my fault. As for PRs, I've always done that previously, but these days they tend to go unnoticed. And I thought Phabricator was for comitters only. If that's not the case, do I create a review there and add people myself? That has always seemed a bit presumptuous! Or is it a case of create PR/review, and then notify the appropriate mailing list? If so, when is it appropriate to use phabricator over PR, and vice verca? I'm an old dog still used to "send-pr", but I'm happy to learn the new tricks! :-) Cheers, Jamie