From owner-freebsd-ports@freebsd.org Mon Aug 15 13:02:34 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE3C4BB9BD5 for ; Mon, 15 Aug 2016 13:02:34 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id A0A2F135F for ; Mon, 15 Aug 2016 13:02:34 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id CCF05BDDC1; Mon, 15 Aug 2016 15:02:31 +0200 (CEST) Received: from atuin.in.mat.cc (global-5-13.nat-1.net.cam.ac.uk [131.111.5.13]) by prod2.absolight.net (Postfix) with ESMTPA id 83B49BDDBC; Mon, 15 Aug 2016 15:02:31 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by atuin.in.mat.cc (Postfix) with ESMTP id 06FC26724CFD; Mon, 15 Aug 2016 14:02:30 +0100 (BST) Date: Mon, 15 Aug 2016 14:02:30 +0200 From: Mathieu Arnold To: Chris Rees , Warren Block cc: freebsd-ports@FreeBSD.org Subject: Re: What happened to 'make missing'? Message-ID: <1EEF29CB43EF28E65398F88D@atuin.in.mat.cc> In-Reply-To: <57AE3532.9040503@physics.org> References: <57AE1D14.7030704@physics.org> <57AE2B10.7060109@physics.org> <57AE3532.9040503@physics.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="==========AFAFDDFE4CCD42DDA70C==========" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2016 13:02:35 -0000 --==========AFAFDDFE4CCD42DDA70C========== Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline +--On 12 ao=C3=BBt 2016 21:44:34 +0100 Chris Rees = wrote: | Hi Warren (and others on the list) |=20 | Chris Rees wrote: |> Warren Block wrote: |>> On Fri, 12 Aug 2016, Chris Rees wrote: |>>=20 |>>> Warren Block wrote: |>>>> The missing target used to be very useful to see what impact=20 |>>>> installing a new port would have. |>>>>=20 |>>>> It seems to be increasingly broken. On my desktop, any random port=20 |>>>> claims that misc/dejagnu and lang/expect are missing. Neither are=20 |>>>> installed, neither is installed as a dependency for any port where |>>>> 'make missing' claims they are needed. |>>>>=20 |>>>> While trying to figure out which part of the recent clamav update=20 |>>>> wanted to pull in sphinx-doc for python, it seems even worse. |>>>>=20 |>>>> Clamav is installed, and did not install any additional ports=20 |>>>> before installing. Yet 'make missing' shows this: |>>>>=20 |>>>=20 |>>> Hey Warren, |>>>=20 |>>> What is the output of: |>>>=20 |>>> # make -C/usr/ports//security/clamav all-depends-list |>>=20 |>>=20 |> OK, and cat /etc/make.conf? |>=20 |> Chris |>=20 | Following our IRC conversation, I have distilled the issue down to: |=20 | make missing checks every single dependency recursively |=20 | This means, for example, that make missing will list sphinx as a missing | dependency, because llvm36 build-depends on it. However, you already | have llvm36 installed, resulting in a bogus 'missing' sphinx, even though | it won't be needed. |=20 | In my view, make missing should recurse only for actual missing | dependencies; |=20 |# find_missing origin |# Finds missing dependencies | find_missing() { | # check for installed of unified depends list (of ONLY $1) |=20 | for d in ${found_deps_that_are_not_installed}; do | find_missing $d | done | } |=20 | Does anyone disagree? Unfortunately I can't prove that the behaviour was | anything other than the current one, which I think is wrong. Please see | relevant (I think) changes below. Something changed, at one point, make missing used to work right. Could you open a PR with all that information, so that it doesn't get lost = ? --=20 Mathieu Arnold --==========AFAFDDFE4CCD42DDA70C========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJXsb1mXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IGO8P/0eYUyhg4Pgc9d6OUihM2uvs OBltyluTfpMoxcYLaU/Cbbfca3ZAy4a7rHbpvu60VeTe959xEyXPhah2D48yTV/e BUpxWKRJKXjNYL17k6a9UYU349dlG1n9I7jwgtKUbIAfauDPwYFSeUY9RAzJj4ec Pa+j95li0rMeoepvjFHf5H0yVpCBMJfLmCwHvN3A2GnrDvFY+4AK3Gs5OVz81Lns TbeuQITu1kzxMAHiJgIMRg2rsYSsDPJ9ViZtpp4Q9pbJ/HNed1AbNYsB1pRJDYRu MdSicL47r+65WE97sBtshT+PaGCY6ppDDxhU6YpHkAr296CZOrG/Y1Qnr2SshAUt hwMiuNcJAZjDPmV9bu3LEdoUWU0SMFrM3M9JTZaaa7epiUUDmb8eLNVmeOVxUOCC XzVj93fFKJLYAba38QZ0HOc6KRgiiF7RvJC6MbjlZePtsf6oyHSiLBx/kBfx/MdV 5N9zOEkjJvC6VxoX9ddBXzzIKyQE0Qv3/Nc+0LKde71eCmLIXIVrf9bbXO5H2JfL D0DeHLSYhcooUMAsmAHBhEQwbV8eOYLd16QwqZ6cq5tkM4ZqQlZ4R3iTHv03bcEl 8RJWmgWa9P9UMLUQZnk4ktbuaJp+dQk5360XGzbBURoYMUpgFW5EZp2vzZM/i7Le 9RlegSc9wPYn4sbmrxpd =TYMC -----END PGP SIGNATURE----- --==========AFAFDDFE4CCD42DDA70C==========--