From owner-freebsd-bugs  Fri Jul 13  1:50:11 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 59CD937B403
	for <freebsd-bugs@hub.freebsd.org>; Fri, 13 Jul 2001 01:50:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f6D8o1J41497;
	Fri, 13 Jul 2001 01:50:01 -0700 (PDT)
	(envelope-from gnats)
Received: from mgate08.so-net.ne.jp (mgate08.so-net.ne.jp [210.139.254.155])
	by hub.freebsd.org (Postfix) with ESMTP id 7EB5D37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 13 Jul 2001 01:42:02 -0700 (PDT)
	(envelope-from sanewo@ba2.so-net.ne.jp)
Received: from mail.ba2.so-net.ne.jp (mail.ba2.so-net.ne.jp [210.139.254.21])
	by mgate08.so-net.ne.jp (8.8.8+3.0Wbeta9/3.6W01060506) with ESMTP id RAA26251
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 13 Jul 2001 17:42:00 +0900 (JST)
Received: from ba2.so-net.ne.jp (pd300b1.tkyoea00.ap.so-net.ne.jp [61.211.0.177])
	by mail.ba2.so-net.ne.jp  with ESMTP id f6D8g0H01401
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 13 Jul 2001 17:42:00 +0900 (JST)
Received: (from sanewo@localhost)
	by ba2.so-net.ne.jp (8.11.4/8.11.4) id f6D8fxk30069;
	Fri, 13 Jul 2001 17:41:59 +0900 (JST)
	(envelope-from sanewo)
Message-Id: <200107130841.f6D8fxk30069@ba2.so-net.ne.jp>
Date: Fri, 13 Jul 2001 17:41:59 +0900 (JST)
From: Takanori Saneto <sanewo@ba2.so-net.ne.jp>
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.113
Subject: bin/28935: syslogd -u doesn't treat * as "all levels"
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         28935
>Category:       bin
>Synopsis:       syslogd -u doesn't treat * as "all levels"
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 13 01:50:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Takanori Saneto
>Release:        FreeBSD 4.3-STABLE i386
>Organization:
an individual
>Environment:
System: FreeBSD muse.sanewo 4.3-STABLE FreeBSD 4.3-STABLE #3: Fri Jul 6 01:38:21 JST 2001 sanewo@muse.sanewo:/export/usr.obj/usr/src/sys/MUSE i386

4.3-stable CVSup'ed as of today.
Same problem seems to exist in -current as well.

>Description:

When invoked with -u, syslogd logs nothing to all.log with following
syslog.conf entry:

*.*	/var/log/all.log

 In syslogd.c, '*' is converted to priority level LOG_PRIMASK+1.
 Without -u, default comparison is '>=' and LOG_PRIMASK+1 is larger
than any actual priority level, comparison always succeeds (as
intended).
 With -u, comparison is '==' and no actual priority level is equal to
LOG_PRIMASK+1, comparison always fails.

>How-To-Repeat:

Invoke syslogd with -u and see all.log doesn't grow.

>Fix:

A quick hack patch is as follows:

--- syslogd.c.orig	Fri Jul 13 17:30:46 2001
+++ syslogd.c	Fri Jul 13 17:31:55 2001
@@ -809,6 +809,7 @@
 		if (!(((f->f_pcmp[fac] & PRI_EQ) && (f->f_pmask[fac] == prilev))
 		     ||((f->f_pcmp[fac] & PRI_LT) && (f->f_pmask[fac] < prilev))
 		     ||((f->f_pcmp[fac] & PRI_GT) && (f->f_pmask[fac] > prilev))
+		     ||(f->f_pmask[fac] == LOG_PRIMASK+1)
 		     )
 		    || f->f_pmask[fac] == INTERNAL_NOPRI)
 			continue;

>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message