From owner-freebsd-current@FreeBSD.ORG Fri Mar 12 11:02:22 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D6CC106564A for ; Fri, 12 Mar 2010 11:02:22 +0000 (UTC) (envelope-from uqs@spoerlein.net) Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2001:470:9a47::1]) by mx1.freebsd.org (Postfix) with ESMTP id 27FEA8FC08 for ; Fri, 12 Mar 2010 11:02:22 +0000 (UTC) Received: from acme.spoerlein.net (localhost.spoerlein.net [IPv6:::1]) by acme.spoerlein.net (Postfix) with ESMTPS id 6334F5CA9; Fri, 12 Mar 2010 12:02:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=spoerlein.net; s=dkim200908; t=1268391741; bh=HJoaB7NqNmgfhuFfoE7+CL0dobMJbbPN18QfNMnfFbE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=fUPq3jWzDH6M/hUUPm3Sg4oIbcPvhlN5knEHBEPB4rItFetxT/1moIXdws8rtfJgv Pcpp5kUuGHhimJh/DOcJSp/uaj3EQRGLgsBpjpzXMUY2LI2suyaA0ctTN0/jx0T3Sq VWHSmSQuNkJ2GVi5RGBfQUFckPoez10De8U9LR3w= Received: (from uqs@localhost) by acme.spoerlein.net (8.14.4/8.14.4/Submit) id o2CB2L35003033; Fri, 12 Mar 2010 12:02:21 +0100 (CET) (envelope-from uqs@spoerlein.net) Date: Fri, 12 Mar 2010 12:02:21 +0100 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: Gary Jennejohn Message-ID: <20100312110221.GC99813@acme.spoerlein.net> Mail-Followup-To: Gary Jennejohn , Garrett Cooper , freebsd-current@freebsd.org References: <4B991C00.3010809@intertainservices.com> <790a9fff1003111714s58d9ee4bl6454d1d52bf705b8@mail.gmail.com> <7d6fde3d1003111720g7dccf93w1f51db88758a5c4d@mail.gmail.com> <20100311.192423.683591382013853731.imp@bsdimp.com> <7d6fde3d1003112024o646afbf2w1ee4d81abae7e608@mail.gmail.com> <20100312113625.1b2b017f@ernst.jennejohn.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100312113625.1b2b017f@ernst.jennejohn.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Garrett Cooper , freebsd-current@freebsd.org Subject: Re: HEADS UP: COMPAT_IA32 renamed COMPAT_FREEBSD32 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2010 11:02:22 -0000 On Fri, 12.03.2010 at 11:36:25 +0100, Gary Jennejohn wrote: > On Thu, 11 Mar 2010 20:24:57 -0800 > Garrett Cooper wrote: > > > I can haz PR review then? Here's an easy one :)... > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=144644 > > > > Looks OK to me except I don't like the > if (something) { > one-line-of-code(); > } > constructs, but according to style(9) these are sort-of OK, viz > > Closing and opening braces go on the same line as the else. Braces that > are not necessary may be left out. > ^^^^^^^^^^^^^^^ > if (test) > stmt; > else if (bar) { > stmt; > stmt; > } else > stmt; > > Saved by the "may." True, but some folks (me included) really hate it, when different bracing is used *within* the same statement. The example above really is horrible. If one if/else-if clause needs braces, just brace them all. This loses no vertical space (the dangling else excluded) and some folks find it visually more pleasing/easier to read. ... hence begins the bikeshedding. Bye, Uli