From owner-cvs-src@FreeBSD.ORG  Thu Oct  6 15:48:17 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F141116A41F;
	Thu,  6 Oct 2005 15:48:16 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from viefep16-int.chello.at (viefep16-int.chello.at [213.46.255.17])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 72CD143D46;
	Thu,  6 Oct 2005 15:48:14 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep16-int.chello.at
	(InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id
	<20051006154812.UMCV7335.viefep16-int.chello.at@wombat.fafoe.narf.at>;
	Thu, 6 Oct 2005 17:48:12 +0200
Received: by wombat.fafoe.narf.at (Postfix, from userid 1001)
	id 84FFC212; Thu,  6 Oct 2005 17:48:02 +0200 (CEST)
Date: Thu, 6 Oct 2005 17:48:02 +0200
From: Stefan Farfeleder <stefanf@FreeBSD.org>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Message-ID: <20051006154754.GH603@wombat.fafoe.narf.at>
References: <200510061110.j96BAApc034176@repoman.freebsd.org>
	<20051006132738.GG603@wombat.fafoe.narf.at>
	<20051006144454.GF23662@garage.freebsd.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051006144454.GF23662@garage.freebsd.pl>
User-Agent: Mutt/1.5.11
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/libkern strtok.c src/sys/sys libkern.h
	src/sys/conf files
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Oct 2005 15:48:17 -0000

On Thu, Oct 06, 2005 at 04:44:54PM +0200, Pawel Jakub Dawidek wrote:
> On Thu, Oct 06, 2005 at 03:27:40PM +0200, Stefan Farfeleder wrote:
> +> On Thu, Oct 06, 2005 at 11:10:10AM +0000, Pawel Jakub Dawidek wrote:
> +> > pjd         2005-10-06 11:10:10 UTC
> +> > 
> +> >   FreeBSD src repository
> +> > 
> +> >   Modified files:
> +> >     sys/sys              libkern.h 
> +> >     sys/conf             files 
> +> >   Added files:
> +> >     sys/libkern          strtok.c 
> +> >   Log:
> +> >   Add strtok() and strtok_r() function to libkern.
> +> 
> +> Wouldn't it be better to have strsep() instead?
> 
> Actually we do have strsep() libkern already...

Oops.  Can you please change nfs_diskless.c to use strsep()?  I think
it's a mistake to add non-reentrant functions to libkern.

Stefan