From owner-svn-src-head@freebsd.org Wed Aug 26 22:08:26 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A05D09C3A02; Wed, 26 Aug 2015 22:08:26 +0000 (UTC) (envelope-from dumbbell@FreeBSD.org) Received: from mail.made4.biz (mail.made4.biz [IPv6:2001:41d0:2:c018::1:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6808F37F; Wed, 26 Aug 2015 22:08:26 +0000 (UTC) (envelope-from dumbbell@FreeBSD.org) Received: from 141.7.19.93.rev.sfr.net ([93.19.7.141] helo=magellan.dumbbell.fr) by mail.made4.biz with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1ZUiro-000DSO-I6; Thu, 27 Aug 2015 00:08:24 +0200 Subject: Re: svn commit: r287174 - head/sys/dev/drm2/i915 To: Konstantin Belousov , Baptiste Daroussin References: <201508262135.t7QLZGs7067675@repo.freebsd.org> <20150826215311.GF2072@kib.kiev.ua> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= X-Enigmail-Draft-Status: N1110 Message-ID: <55DE38D3.9000802@FreeBSD.org> Date: Thu, 27 Aug 2015 00:08:19 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150826215311.GF2072@kib.kiev.ua> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JX8oBuanCh7H3WFBEfOSPOQuAmjTVFtmt" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2015 22:08:26 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JX8oBuanCh7H3WFBEfOSPOQuAmjTVFtmt Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 26.08.2015 23:53, Konstantin Belousov wrote: > On Wed, Aug 26, 2015 at 09:35:16PM +0000, Baptiste Daroussin wrote: >> -static bool >> +static inline bool >> i915_gem_object_is_inactive(struct drm_i915_gem_object *obj) >> { >> - >> - return !obj->active; >> + return obj->gtt_space && !obj->active; > > Why is this correct ? obj->gtt_space is NULL when the object is not mapped in the global GTT. This check was added in 6c085a728cf000ac1865d66f8c9b52935558b328 ("drm/i915: Track unbound pages"), first released in Linux 3.7. But now that I think of it again, it may not be correct with the current driver (and only correct in the context of a 3.8-era driver). Baptiste, could you please revert that part? --=20 Jean-S=E9bastien P=E9dron --JX8oBuanCh7H3WFBEfOSPOQuAmjTVFtmt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJV3jjYXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NzA4N0ZEMUFFQUUwRTEyREJDNkE2RjAz OUU5OTc2MUE1RkQ5NENDAAoJEDnpl2Gl/ZTMWpUQAIDrMeaZpbm2sHif6Hos2rVE 2hIsVuNGyfq+SINnJgMLM2azhHy43iRpLmhpa9cNirWGQ2yqVmYnXsEsQib507ak D+SWkesp9Rq1Ov3FwMNLr1kFefkBpzsDNf/O986xXvnwn69i9/tScfwTvBNMjLGx lpAlIuW8GN848hO3R/zBk6XRlvNfa0hwC5A2xWv2oZBmLO1gYlhn8HHdpUSlv40U KGmTnbt3PaatCvxiXPXsE0oZNnqKQEUeLmfiPO2kaN5YxhNiVbRRvVhOyghFBlhU KpEbRPOtXDeS6V7PEGGgnX7eceOJOr6aW6jBFcWOUksexgUngZRQFbP7hLRXiDyS g64w7MJZFIVROJ3aX35TX3MYSRDq1FzXYWwJ0hGzaLIp86zCS+EQZ06m9y0C8xjU bW0ZCCBJ9VB7Wtuf6fh6Cd+KbWJ2bIWVNkJkYJPQvmUoSOeZHNnq1SRDBmiTD3BN B2k5r/dwILsi3VT0w0/C7sxOVfmTGUyDHvPTQbZsJedHoSgxqsgWW6aXglDbYCQV ZfFYjUluv8uNF7H6zO2iiLbvqyStIEhSlGbFXF24+2/3vWgip548xQcuHotezaal ALL5jKw3DMtDwFCy40Az1oV2OzESHbP9vH9NSdXBQP+ngySkZWRfUAZ54bF2VaVb s+XWyATdI6wUmgOzJ+9o =6eac -----END PGP SIGNATURE----- --JX8oBuanCh7H3WFBEfOSPOQuAmjTVFtmt--