From owner-freebsd-java@FreeBSD.ORG  Wed Jun 30 17:31:32 2004
Return-Path: <owner-freebsd-java@FreeBSD.ORG>
Delivered-To: freebsd-java@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B5F9816A4CE; Wed, 30 Jun 2004 17:31:32 +0000 (GMT)
Received: from mail.soaustin.net (mail.soaustin.net [207.200.4.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 948BC43D48; Wed, 30 Jun 2004 17:31:32 +0000 (GMT)
	(envelope-from linimon@lonesome.com)
Received: by mail.soaustin.net (Postfix, from userid 502)
	id 2843514859; Wed, 30 Jun 2004 12:31:29 -0500 (CDT)
Date: Wed, 30 Jun 2004 12:31:29 -0500 (CDT)
From: Mark Linimon <linimon@lonesome.com>
X-X-Sender: linimon@pancho
To: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
In-Reply-To: <200406301452.i5UEqWb7091785@arabica.esil.univ-mrs.fr>
Message-ID: <Pine.LNX.4.44.0406301225530.32355-100000@pancho>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: glewis@FreeBSD.org
cc: FreeBSD-gnats-submit@FreeBSD.org
cc: linimon@FreeBSD.org
cc: znerd@FreeBSD.org
cc: freebsd-java@FreeBSD.org
Subject: Re: java/68516: [PATCH] bsd.kava.mk: re-apply previous PR
	improvements
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-java>,
	<mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jun 2004 17:31:32 -0000

On Wed, 30 Jun 2004, Herve Quiroz wrote:

> Ironically, I realized by doing this patch that the original patch from Mark
> seemed to be broken regarding bsd.java.mk (a typo: "check-makevers" ->
> "check-makevars").

Yep, just a typo.  I vaguely remember doing some regression testing
with setting up bogus user environments and trying to exercise each
code path, but I must have missed that one.

For those that don't understand the impact of the changes, they are
designed to allow 'make index' and 'make search' to succeed despite
any bogus user environment.  The use of .BEGIN or .error directives
in Makefiles introduces such fragility; they should only be used in
cases to indicate that the ports infrastructure itself is broken
(has had a bad commit to the master repository), rather than that
there is some invalid setup on an individual machine.

And yes, I know that we have a number of these scattered around.
They all need to be fixed.