From owner-p4-projects@FreeBSD.ORG  Wed Nov  5 20:19:24 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B575316A4D2; Wed,  5 Nov 2003 20:19:23 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9147816A4CF
	for <perforce@freebsd.org>; Wed,  5 Nov 2003 20:19:23 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 149B943F3F
	for <perforce@freebsd.org>; Wed,  5 Nov 2003 20:19:23 -0800 (PST)
	(envelope-from peter@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id hA64JMXJ082727
	for <perforce@freebsd.org>; Wed, 5 Nov 2003 20:19:22 -0800 (PST)
	(envelope-from peter@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.9/8.12.9/Submit) id hA64JMaV082724
	for perforce@freebsd.org; Wed, 5 Nov 2003 20:19:22 -0800 (PST)
	(envelope-from peter@freebsd.org)
Date: Wed, 5 Nov 2003 20:19:22 -0800 (PST)
Message-Id: <200311060419.hA64JMaV082724@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	peter@freebsd.org using -f
From: Peter Wemm <peter@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 41554 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Nov 2003 04:19:24 -0000

http://perforce.freebsd.org/chv.cgi?CH=41554

Change 41554 by peter@peter_daintree on 2003/11/05 20:18:27

	note that the gdt allocation still needs to be resolved.  The tss
	needs to be per-cpu still.  note to self: ltr appears to load
	the address of the tss into the hidden tss register.  we may not
	need a per-cpu gdt just to load a tss.

Affected files ...

.. //depot/projects/hammer/sys/amd64/amd64/mp_machdep.c#25 edit

Differences ...

==== //depot/projects/hammer/sys/amd64/amd64/mp_machdep.c#25 (text+ko) ====

@@ -32,7 +32,6 @@
 #include <sys/param.h>
 #include <sys/systm.h>
 #include <sys/bus.h>
-#include <sys/cons.h>	/* cngetc() */
 #ifdef GPROF 
 #include <sys/gmon.h>
 #endif
@@ -490,6 +489,7 @@
 		common_tss[cpu] = common_tss[0];
 		common_tss[cpu].tss_rsp0 = 0;	/* not used until after switch */
 
+		/* XXX not so fast there sonny! */
 		gdt_segs[GPROC0_SEL].ssd_base = (long) &common_tss[cpu];
 
 		for (x = 0; x < NGDT; x++)
@@ -517,13 +517,8 @@
 		bootAP = cpu;
 
 		/* attempt to start the Application Processor */
-		if (!start_ap(apic_id)) {
-			printf("AP #%d (PHY# %d) failed!\n", cpu, apic_id);
-			/* better panic as the AP may be running loose */
-			printf("panic y/n? [y] ");
-			if (cngetc() != 'n')
-				panic("bye-bye");
-		}
+		if (!start_ap(apic_id))
+			panic("AP #%d (PHY# %d) failed!", cpu, apic_id);
 
 		all_cpus |= (1 << cpu);		/* record AP in CPU map */
 	}