Date: Mon, 16 Feb 2004 11:25:55 -0500 (EST) From: Craig Rodrigues <rodrigc@crodrigues.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: phantom@FreeBSD.org Subject: ports/62919: [PATCH] misc/posixtestsuite, respect PTHREAD_LIBS Message-ID: <200402161625.i1GGPtpw059350@h00609772adf0.ne.client2.attbi.com> Resent-Message-ID: <200402161630.i1GGUI1m010615@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 62919
>Category: ports
>Synopsis: [PATCH] misc/posixtestsuite, respect PTHREAD_LIBS
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Mon Feb 16 08:30:17 PST 2004
>Closed-Date:
>Last-Modified:
>Originator: Craig Rodrigues
>Release: FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD 5.2-CURRENT FreeBSD 5.2-CURRENT #33
>Description:
This patch fixes a few things:
- respect ${PTHREAD_LIBS} defined in /usr/ports/Mk/bsd.port.mk
- change a few spaces to tabs to make portlint -A happy
- correct the wording in the WITH_THRLIB documentation
>How-To-Repeat:
>Fix:
--- Makefile.orig Mon Feb 16 11:15:49 2004
+++ Makefile Mon Feb 16 11:21:47 2004
@@ -10,7 +10,7 @@
PORTREVISION= 1
CATEGORIES= misc
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE}
-MASTER_SITE_SUBDIR= posixtest
+MASTER_SITE_SUBDIR= posixtest
MAINTAINER= phantom@FreeBSD.org
COMMENT= Open POSIX Test Suite
@@ -26,9 +26,9 @@
.include <bsd.port.pre.mk>
.if ${OSVERSION} < 500000
-REGR_LOG= log.run-4stable
+REGR_LOG= log.run-4stable
.else
-REGR_LOG= log.run-5current
+REGR_LOG= log.run-5current
.endif
RUN_RESULT= ${WRKSRC}/run.result
@@ -43,7 +43,7 @@
.if defined(WITH_THRLIB)
THRLIB=${WITH_THRLIB}
.else
-THRLIB= -lc_r
+THRLIB= ${PTHREAD_LIBS}
.endif
pre-everything::
@@ -58,12 +58,12 @@
@${ECHO} ""
@${ECHO} " * QUIET - don't print progress messages while running"
@${ECHO} " * WITH_THRLIB - choose thread library to run test against"
- @${ECHO} " (NB: by default 'libc_r' is used)"
+ @${ECHO} " (NB: by default '"${PTHREAD_LIBS}"' is used)"
@${ECHO} ""
@${ECHO} "Examples:"
@${ECHO} ""
- @${ECHO} " make WITH_THRLIB=libkse run"
- @${ECHO} " - run tests against libkse"
+ @${ECHO} " make WITH_THRLIB=-lpthread run"
+ @${ECHO} " - run tests against libpthread"
@${ECHO} ""
@${ECHO} " make QUIET=YES WITH_THRLIB= regression"
@${ECHO} " - be quiet, run tests against libc, compare tests results"
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200402161625.i1GGPtpw059350>