From owner-freebsd-testing@FreeBSD.ORG Fri Nov 1 20:00:01 2013 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 58F56134 for ; Fri, 1 Nov 2013 20:00:01 +0000 (UTC) (envelope-from julio@meroh.net) Received: from mail-lb0-f180.google.com (mail-lb0-f180.google.com [209.85.217.180]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D9BE724BD for ; Fri, 1 Nov 2013 20:00:00 +0000 (UTC) Received: by mail-lb0-f180.google.com with SMTP id y6so3857112lbh.11 for ; Fri, 01 Nov 2013 12:59:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=R6587t6OZdTuCQlHH1aE/ZYUPCBI/bpXK9ERUSSjhrs=; b=fMnQfpvfDx3kT6glUenKLTjkSfJLB0hHJy91dGw2do8Imw+39PtGtzPWrLXCGydXck ahBx0wEYp98KqcOotJnGrxLBFo4yHkUFws0y2rtE2lug1e1Zy0BGsnspNrWHvvZ2mjPt ilg7NsT+MaASCOkCEYrSLm/ifg982oqz0ORI9gGQo8tQ2M6It2xys3El0+aXokE9xeVS tHuHWVfaXjurWO94BEQhGv3SlqNDlDrVz4KD0b3uUCKmhlIPglA5yZ07CQiCJl4eInTy w3mMjDMk25/CjChWXudXfFuiHvf9PS7kbx82lnBwqE/9Sg5+LXepXGZZhcdtcvU5Ux/J bilQ== X-Gm-Message-State: ALoCoQmm8ytEq/Fg/tll3urCO55/kIg37AcD1EtloZzX7iDKnhfM7te3q9cg3ZKG+YqKa8HrvWT2 X-Received: by 10.112.210.66 with SMTP id ms2mr583235lbc.51.1383335992129; Fri, 01 Nov 2013 12:59:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.132.135 with HTTP; Fri, 1 Nov 2013 12:59:32 -0700 (PDT) X-Originating-IP: [2620:0:1003:1007:118a:cb85:ffd3:6ebd] In-Reply-To: <20131030181508.84F085807E@chaos.jnpr.net> References: <20131029203658.75BF35807E@chaos.jnpr.net> <20131030181508.84F085807E@chaos.jnpr.net> From: Julio Merino Date: Fri, 1 Nov 2013 15:59:32 -0400 Message-ID: Subject: Re: Plugging ATF tests into the build and other cleanups To: "Simon J. Gerraty" Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-testing@freebsd.org, Rui Paulo X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Nov 2013 20:00:01 -0000 On Wed, Oct 30, 2013 at 2:15 PM, Simon J. Gerraty wrote: > > On Tue, 29 Oct 2013 17:46:19 -0400, Julio Merino writes: >>> freebsd-testing/move-kyuafiles.diff >>> >>> I'm also not crazy about this one (the change to lib/Makefile) >>> What is the expected use? >> >>To populate /usr/tests/lib accordingly. You need: >> >>/usr/tests/Kyuafile - auto-recurse into directories >>/usr/tests/lib/Kyuafile - auto-recurse into directories >>/usr/tests/lib/libc/Kyuafile - list of tests to run and possibly other >>subdirectories >>and that /usr/tests/lib/Kyuafile has to come from somewhere. I think > > Sure, but if Kyuafile works anything like Atffile, a generic boilerplate > one would do? and this could be handled from almost anywhere. > Since we (junos - and same in projects/bmake) ignore intermediate > makefiles like lib/ etc, that wouldn't be my choice. Aha! I think the "ignore intermediate makefiles" part is the key piece I was missing to understand your build system. >>Note: I have applied some of your suggestions to the existing patches >>but some things still remain open so don't bother doing an in-depth >>review again because they are broken. However, I gotta go now and I'd >>prefer to send this out for further comments while I have your >>attention ;) > > Sure - thanks very much for your help. FYI: Please note that I already sent another message with more complete responses. You might have missed it since they were both similar in content and possibly strangely threaded. -- Julio Merino / @jmmv