From owner-cvs-src@FreeBSD.ORG  Fri Aug 22 16:22:14 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C3A571065675;
	Fri, 22 Aug 2008 16:22:14 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 9ACE28FC15;
	Fri, 22 Aug 2008 16:22:14 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from trouble.errno.com (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m7MGMDoC094805
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 22 Aug 2008 09:22:14 -0700 (PDT) (envelope-from sam@freebsd.org)
Message-ID: <48AEE7B5.7090700@freebsd.org>
Date: Fri, 22 Aug 2008 09:22:13 -0700
From: Sam Leffler <sam@freebsd.org>
Organization: FreeBSD Project
User-Agent: Thunderbird 2.0.0.9 (X11/20071125)
MIME-Version: 1.0
To: Pyun YongHyeon <yongari@freebsd.org>
References: <200808220647.m7M6lAeL097786@repoman.freebsd.org>
In-Reply-To: <200808220647.m7M6lAeL097786@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC--Metrics: ebb.errno.com; whitelist
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/bfe if_bfe.c if_bfereg.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Aug 2008 16:22:14 -0000

Pyun YongHyeon wrote:
> yongari     2008-08-22 06:46:55 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/dev/bfe          if_bfe.c if_bfereg.h 
>   Log:
>   SVN rev 181994 on 2008-08-22 06:46:55Z by yongari
>   
>   Add a new sysctl node 'dev.bfe.N.stats' that shows various MAC
>   counters for Rx/Tx statistics. Various counters in ifnet is also
>   updated with these hardware counters.
>   
>   
Can we not add stuff like that spews output to the console?  I much 
prefer to see a tool that dumps the stats and if you need to get to them 
w/o the tool then consider adding a ddb cmd.  We're just about to get 
the ability to add ddb cmds in loadable modules which was the only 
reason not to leverage ddb for stuff like this.

I see this done in several drivers and hate it.  I'd like to see this 
approach not be copied in the future.

    Sam