From owner-freebsd-fs@FreeBSD.ORG Wed Jun 2 09:45:09 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F4BB1065672 for ; Wed, 2 Jun 2010 09:45:09 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id BDD6E8FC0C for ; Wed, 2 Jun 2010 09:45:08 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o529jIHA065303 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 2 Jun 2010 12:45:18 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o529j5B3053900; Wed, 2 Jun 2010 12:45:05 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o529j4ja053899; Wed, 2 Jun 2010 12:45:04 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 2 Jun 2010 12:45:04 +0300 From: Kostik Belousov To: Mikolaj Golub Message-ID: <20100602094504.GN83316@deviant.kiev.zoral.com.ua> References: <86fx16onx6.fsf@zhuzha.ua1> <20100601140721.GH83316@deviant.kiev.zoral.com.ua> <86bpbtonma.fsf@zhuzha.ua1> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b385GY4hqirqljNZ" Content-Disposition: inline In-Reply-To: <86bpbtonma.fsf@zhuzha.ua1> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_50, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-fs@freebsd.org Subject: Re: nullfs: vop_rename: fdvp is locked but should not be X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2010 09:45:09 -0000 --b385GY4hqirqljNZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 02, 2010 at 11:16:45AM +0300, Mikolaj Golub wrote: >=20 > KB> I am curious to look at the final patch. Note that you proposing to = add > KB> fs-specific check to vfs_subr.c. Checking that the the vnode locks a= re > KB> different instead of that vnodes itself are different might be better > KB> approach for vop_rename_pre. >=20 > Ok. Looks a bit tricky :-). Then may be it is safe just to skip ASSERT() = if > the "target" and "from" vnodes are on different fs, like in the patch bel= ow? >=20 > I have tried the patch on CURRENT. It looks like it works... I do not think that the attached patch is the right solution Again, try. comparing the pointers to the vnode locks instead of the vnode pointers. Something like if (a->a_tdvp->v_vnlock !=3D a->a_fdvp->v_vnlock ... --b385GY4hqirqljNZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkwGKCAACgkQC3+MBN1Mb4gIzgCgkt+FR7+AVpfA5R6eVv9lDLR+ KlcAoOcSTkG0ircVSI5sFDcc3h9BgFXJ =5xvT -----END PGP SIGNATURE----- --b385GY4hqirqljNZ--