From owner-freebsd-hackers Thu Feb 27 05:29:05 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id FAA25919 for hackers-outgoing; Thu, 27 Feb 1997 05:29:05 -0800 (PST) Received: from nic.follonett.no (nic.follonett.no [194.198.43.10]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id FAA25885; Thu, 27 Feb 1997 05:28:28 -0800 (PST) Received: (from uucp@localhost) by nic.follonett.no (8.8.5/8.8.3) with UUCP id OAA03643; Thu, 27 Feb 1997 14:26:31 +0100 (MET) Received: from oo7 (oo7.dimaga.com [192.0.0.65]) by dimaga.com (8.8.5/8.7.2) with SMTP id OAA14618; Thu, 27 Feb 1997 14:29:02 +0100 (MET) Message-Id: <3.0.32.19970227142902.00bccd30@dimaga.com> X-Sender: eivind@dimaga.com X-Mailer: Windows Eudora Pro Version 3.0 (32) Date: Thu, 27 Feb 1997 14:29:03 +0100 To: Brian Somers From: Eivind Eklund Subject: Re: Include files (in ppp) Cc: hackers@freebsd.org, eivind@freebsd.org, bde@zeta.org.au, brian@utell.co.uk Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: owner-hackers@freebsd.org X-Loop: FreeBSD.org Precedence: bulk At 01:23 AM 2/27/97 +0000, Brian Somers wrote: >I'd suggest one of the following: > >- Leave it as it is (with osreldate.h adding partially to the chaos) >- Remove all of the #ifs buts and whys (rationalle: If osreldate isn't > in there, All the #if BSD etc stuff is useless anyway) I'd say this depend on a few things: (A) How many patches to IIJ-PPP do we recieve? If there are a lot of these, removing #ifdefs might disrupt merging. (Doesn't look like it from the amount of commits, though.) (B) Is IIJ-PPP actively developed anywhere outside FreeBSD? See (A). (PPP+pktAlias doesn't count - I'll merge any changes from -current) (C) Is IIJ-PPP from FreeBSD actively used by non-FreeBSD people? In this case, we could pay them the courtesy of leaving it in. If none of these factors give us trouble, I'd say we cut the #ifdef's - they clutter the code. However, the final choice is in Brian's hands - as well as the responsibility for adding himself as maintainer in the Makefile ;-) Eivind Eklund perhaps@yes.no http://maybe.yes.no/perhaps/ eivind@freebsd.org