From owner-svn-src-head@freebsd.org Tue Dec 5 20:32:07 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8AE2E806F0; Tue, 5 Dec 2017 20:32:07 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2DFB26DD1D; Tue, 5 Dec 2017 20:32:06 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id MJeDeX3YJGvLHMJeEeklaL; Tue, 05 Dec 2017 13:17:00 -0700 X-Authority-Analysis: v=2.2 cv=a9pAzQaF c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=ocR9PWop10UA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=BWvPGDcYAAAA:8 a=ndaoGXS1AAAA:8 a=3LhwCfBeHoEQoLPJ3MgA:9 a=L3bb61WgntlLSfa0:21 a=OSfL2kd0QOkLvTrr:21 a=CjuIK1q_8ugA:10 a=-FEs8UIgK8oA:10 a=NWVoK91CQyQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=pxhY87DP9d2VeQe4joPk:22 a=mFeOnlTyF09QQMGr2mMI:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 867E55AE; Tue, 5 Dec 2017 12:16:56 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id vB5KGc3v038429; Tue, 5 Dec 2017 12:16:38 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id vB5KGc9T038423; Tue, 5 Dec 2017 12:16:38 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201712052016.vB5KGc9T038423@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Eitan Adler cc: Eric Joyner , Cy Schubert , Devin Teske , Hans Petter Selasky , "rgrimes@freebsd.org" , "cem@freebsd.org" , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee In-Reply-To: Message from Eitan Adler of "Tue, 05 Dec 2017 10:29:47 -0800." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 05 Dec 2017 12:16:38 -0800 X-CMAE-Envelope: MS4wfKLQGyV8RJRB1EPt0rPHqgehmzBw/htMWGY/jymnSxNBzlWHh/j8S8zsyn89zkcwu2TaVtfaJSSwuVsBhiN6reZScibjG5M8xdZACMLf6RD4y0AEtTwb rroakvyS3RyOtVM6ONfyuKD4r1w1FnRFeg4JHu6R9PdnScf2k9UDKHZ/XVNPOe72KI2XmH2M18AJ1ZW10M7ri/O99ACbJU4zCizShG7lTKfCmzt2Rky1r4tk qsnvOdpYvcHvVcfc+LNUfTEbsUxx3eR/iJxNuMnsB3nYD4KH6d5BGyQ/yhSncJxTyHK8tRD0005eyaw1w11pS177lPiKttr7HXnZ8caiOALI6+9CtrYS31mp dl5rnBJD37AQhxdlLXDNmLr7ogu989UnURYerRoOgZsRHcwOlSW5CKOcUUGo6is2iZG4I3AA X-Mailman-Approved-At: Tue, 05 Dec 2017 20:54:08 +0000 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 20:32:07 -0000 In message , Eitan Adler writes: > I'm not near my commit box right now so someone will have to revert > it. What's funny is that I ran a complete 'make buildworld > buildkernel' last night with this patch. > > Will respond to the rest of the thread later No problem. r326575 addresses the issue. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. > > On 5 December 2017 at 10:08, Eric Joyner wrote: > > I got told by a co-worker that this broke buildworld. Can this commit get > > reverted/have the cast fixed? > > > > - Eric (erj) > > > > > > On Tue, Dec 5, 2017 at 9:50 AM Cy Schubert wrote > : > >> > >> Our sed already creates backup files "optionally" just as gsed does. Only > >> the syntax is different. No need to sponge sed, just sed -i '' (whereas gs > ed > >> is -i without the argument). > >> > >> > >> --- > >> Sent using a tiny phone keyboard. > >> Apologies for any typos and autocorrect. > >> This old phone only supports top post. Apologies. > >> > >> Cy Schubert > >> or > >> The need of the many outweighs the greed of the few. > >> --- > >> ________________________________ > >> From: Devin Teske > >> Sent: 05/12/2017 09:23 > >> To: Cy Schubert > >> Cc: Hans Petter Selasky; rgrimes@freebsd.org; cem@freebsd.org; Eitan > >> Adler; src-committers; svn-src-all@freebsd.org; svn-src-head@freebsd.org > >> > >> Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge > >> usr.bin/sponge/tests usr.bin/tee > >> > >> > >> On Dec 5, 2017, at 8:29 AM, Cy Schubert wrote: > >> > >> Why not update sed to create the backup file only if the suffix is given > >> to -i, like gnu sed does. > >> > >> > >> I suspect that would break countless scripts that test uname to determine > >> how to use the -i flag of sed. > >> -- > >> Devin > >> > >> > >> --- > >> Sent using a tiny phone keyboard. > >> Apologies for any typos and autocorrect. > >> This old phone only supports top post. Apologies. > >> > >> Cy Schubert > >> or > >> The need of the many outweighs the greed of the few. > >> --- > >> ________________________________ > >> From: Devin Teske > >> Sent: 05/12/2017 07:35 > >> To: Hans Petter Selasky > >> Cc: rgrimes@freebsd.org; cem@freebsd.org; Eitan Adler; src-committers; > >> svn-src-all@freebsd.org; svn-src-head@freebsd.org > >> Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge > >> usr.bin/sponge/tests usr.bin/tee > >> > >> > >> > On Dec 5, 2017, at 5:00 AM, Hans Petter Selasky wrote: > >> > > >> >> On 12/05/17 13:58, Rodney W. Grimes wrote: > >> >> Further more, why does freebsd need this in base? > >> > > >> > Hi, > >> > > >> > I think this is useful. It could replace the "-i " (intermediate) option > >> > for "sed" for example. It avoids creating temporary files when filtering > >> > files, right? > >> > > >> > --HPS > >> > > >> > >> Wth is wrong with: > >> > >> data=$( sed -e '...' somefile ) && > >> echo "$data" > somefile > >> > >> or > >> > >> set -e > >> data=... > >> echo "$data" > ... > >> > >> or > >> > >> exec 3< >> $( ... ) > >> EOF > >> cat > ... <&3 > >> > >> or > >> > >> (I digress) > >> > >> Infinite variations, but the gist is that sponge looks to be trying to > >> help sh(1)/similar when help is unneeded. > >> > >> Why buffer data into memory via fork-exec-pipe to sponge when you can > >> buffer to native namespace without pipe to sponge? > >> > >> Am I missing something? Why do we need sponge(1)? > >> -- > >> Devin > >> > > > > > > -- > Eitan Adler > Source, Ports, Doc committer > Bugmeister, Ports Security teams >