From owner-p4-projects@FreeBSD.ORG  Sun Nov 15 13:03:40 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D3C78106568B; Sun, 15 Nov 2009 13:03:39 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 97A951065672;
	Sun, 15 Nov 2009 13:03:39 +0000 (UTC) (envelope-from olli@fromme.com)
Received: from haluter.fromme.com (haluter.fromme.com [212.17.241.231])
	by mx1.freebsd.org (Postfix) with ESMTP id 20F718FC16;
	Sun, 15 Nov 2009 13:03:38 +0000 (UTC)
Received: from haluter.fromme.com (irc_sucks@localhost [127.0.0.1])
	by haluter.fromme.com (8.14.3/8.14.3) with ESMTP id nAFCQEmh005361;
	Sun, 15 Nov 2009 13:26:21 +0100 (CET) (envelope-from olli@fromme.com)
Received: (from olli@localhost)
	by haluter.fromme.com (8.14.3/8.14.3/Submit) id nAFCQD6g005359;
	Sun, 15 Nov 2009 13:26:13 +0100 (CET) (envelope-from olli)
From: Oliver Fromme <olli@fromme.com>
Message-Id: <200911151226.nAFCQD6g005359@haluter.fromme.com>
To: rene@freebsd.org (Rene Ladan)
Date: Sun, 15 Nov 2009 13:26:13 +0100 (CET)
In-Reply-To: <200911142333.nAENXWrT017367@repoman.freebsd.org>
X-Mailer: ELM [version 2.5 PL8]
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.1.2
	(haluter.fromme.com [127.0.0.1]);
	Sun, 15 Nov 2009 13:26:21 +0100 (CET)
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 170633 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Nov 2009 13:03:40 -0000


Rene Ladan wrote:
 > http://p4web.freebsd.org/chv.cgi?CH=170633
 > 
 > Change 170633 by rene@rene_self on 2009/11/14 23:32:57
 > 
 > 	[porters handbook]
 > 	Add a section about Clang to the "Dos and Don'ts" chapter.
 > 	To be reviewed by the clang team and the doc review team.
 > 
 > Affected files ...
 > 
 > .. //depot/projects/docproj_nl/en_US.ISO8859-1/books/porters-handbook/book.sgml#50 edit
 > 
 > Differences ...
 > 
 > ==== //depot/projects/docproj_nl/en_US.ISO8859-1/books/porters-handbook/book.sgml#50 (text+ko) ====
 > [...]
 > +	  <listitem>
 > +	    <para>Respect <makevar>CC</makevar> and <makevar>CXX</makevar>. Do
 > +	      not any of <filename>cc</filename>, <filename>c99</filename>,
 > +	      <filename>gcc</filename>, <filename>c++</filename>, or
 > +	      <filename>g++</filename> directly.</para>
 > +	  </listitem>

The last sentence is incomplete.
I think it's missing a verb like "do not _use_ any of ... directly".

 > +	  <listitem>
 > +	    <para>The main function must be properly declared as</para>
 > +
 > +	    <programlisting>int main(int argc, char **argv)</programlisting>
 > +	  </listitem>

I think "int main(void)" is also valid if the program doesn't
use any command line arguments, in conformance with the C
standard.  See src/usr/bin/true/true.c for example.

Best regards
   Oliver

-- 
Oliver Fromme, Bunsenstr. 13, 81735 Muenchen, Germany

``We are all but compressed light'' (Albert Einstein)