From owner-svn-src-head@freebsd.org  Wed Sep  2 19:52:00 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BBE8C9C9109;
 Wed,  2 Sep 2015 19:52:00 +0000 (UTC)
 (envelope-from cse.cem@gmail.com)
Received: from mail-yk0-f176.google.com (mail-yk0-f176.google.com
 [209.85.160.176])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7DA3FD9E;
 Wed,  2 Sep 2015 19:52:00 +0000 (UTC)
 (envelope-from cse.cem@gmail.com)
Received: by ykei199 with SMTP id i199so21802860yke.0;
 Wed, 02 Sep 2015 12:51:52 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=mime-version:reply-to:in-reply-to:references:date:message-id
 :subject:from:to:cc:content-type;
 bh=bN8M83yy7DO3aFAWbG9IgW9CDgKmGMerP/swFHNKhyc=;
 b=QKUojOm5k2HdhcKbrU5iOHd2LuPule0SbnDf4rqNjWwcagaDqKJB1mtVJYkmgu6tgi
 HLMQjF+7Pc/4Ul4/pHYRpObO7PiMFVjwIFCvJE2g+A9Wcux58WwM9FtQgZzqoqUX2pSl
 PnBcRRJMbKIHwO5HV2uf+KoJHEOGZVQj7qMFz8mzR1muUZHxnhTM3NBpRswmaotWHsd3
 +zzy+9rdsWoWOqZmcul8bUD3Re0MpnJWXDoERYGRfHnzJJTKWST0STdQqyq9vvNZsD7P
 WTAh7sPfRCBAtlDZFDJ//9td7mj19ptw64Wm965vbrx20soA5vh5SB+Fm2P5W5MdYGEU
 j5vw==
X-Received: by 10.170.35.215 with SMTP id 206mr6156524ykd.33.1441223512660;
 Wed, 02 Sep 2015 12:51:52 -0700 (PDT)
Received: from mail-yk0-f175.google.com (mail-yk0-f175.google.com.
 [209.85.160.175])
 by smtp.gmail.com with ESMTPSA id m187sm21419263ywe.8.2015.09.02.12.51.52
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 02 Sep 2015 12:51:52 -0700 (PDT)
Received: by ykei199 with SMTP id i199so21802476yke.0;
 Wed, 02 Sep 2015 12:51:51 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.170.208.145 with SMTP id z139mr6124162yke.108.1441223511938; 
 Wed, 02 Sep 2015 12:51:51 -0700 (PDT)
Reply-To: cem@FreeBSD.org
Received: by 10.37.48.134 with HTTP; Wed, 2 Sep 2015 12:51:51 -0700 (PDT)
In-Reply-To: <CAG6CVpUwYkd6Dv=LMbVm7KE_QJtMMYwcoXsG3shFj56asUP-PQ@mail.gmail.com>
References: <201509021648.t82Gm451015184@repo.freebsd.org>
 <3589074.YABE6tqvK0@ralph.baldwin.cx>
 <CAG6CVpUwYkd6Dv=LMbVm7KE_QJtMMYwcoXsG3shFj56asUP-PQ@mail.gmail.com>
Date: Wed, 2 Sep 2015 12:51:51 -0700
Message-ID: <CAG6CVpXum1bZYuv4k8W8Vp6WLnaXMURYMX+STRzyUkByVUr_Uw@mail.gmail.com>
Subject: Re: svn commit: r287403 - head/sys/dev/ioat
From: Conrad Meyer <cem@FreeBSD.org>
To: John Baldwin <jhb@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org, jimharris@freebsd.org
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Sep 2015 19:52:00 -0000

https://reviews.freebsd.org/D3552

On Wed, Sep 2, 2015 at 12:15 PM, Conrad Meyer <cem@freebsd.org> wrote:
> On Wed, Sep 2, 2015 at 10:26 AM, John Baldwin <jhb@freebsd.org> wrote:
>> Alternatively you could use pci_restore_state() (before reset) and
>> pci_save_state() (after reset) to restore standard PCI config registers
>> (including MSI/MSI-X) after a reset.
>>
>> This might be more scalable if you want to ensure other PCI config
>> registers (e.g. PCI-e capabilities) are restored after a reset.
>
>
> Hi John,
>
> Do you mean pci_save_state() before reset and pci_restore_state()
> afterwards? Seems reasonable to me.
>
> Thanks,
> Conrad