From owner-freebsd-questions@FreeBSD.ORG Thu Jan 10 02:23:02 2013 Return-Path: Delivered-To: questions@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 36FF0659 for ; Thu, 10 Jan 2013 02:23:02 +0000 (UTC) (envelope-from fbsd8@a1poweruser.com) Received: from mail-03.name-services.com (mail-03.name-services.com [69.64.155.195]) by mx1.freebsd.org (Postfix) with ESMTP id F4103DF3 for ; Thu, 10 Jan 2013 02:23:01 +0000 (UTC) Received: from [10.0.10.3] ([173.88.197.103]) by mail-03.name-services.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 9 Jan 2013 18:23:02 -0800 Message-ID: <50EE2604.4020809@a1poweruser.com> Date: Wed, 09 Jan 2013 21:23:00 -0500 From: Fbsd8 User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Lowell Gilbert Subject: Re: sh script problem with capturing return code References: <50EC9009.3030305@a1poweruser.com> <20130108224626.8c2d89cd.freebsd@edvax.de> <50EC99F2.3020404@a1poweruser.com> <44d2xevlhb.fsf@lowell-desk.lan> <50ED88CF.7060308@a1poweruser.com> <448v82unxb.fsf@lowell-desk.lan> <444niqum7n.fsf@lowell-desk.lan> <44zk0it6t5.fsf@lowell-desk.lan> <44r4ltu8zp.fsf@lowell-desk.lan> In-Reply-To: <44r4ltu8zp.fsf@lowell-desk.lan> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 10 Jan 2013 02:23:02.0663 (UTC) FILETIME=[6A8E3170:01CDEED9] X-Sender: fbsd8@a1poweruser.com X-Authenticated-Sender: fbsd8@a1poweruser.com X-EchoSenderHash: [fbsd8]-[a1poweruser*com] Cc: FreeBSD questions X-BeenThere: freebsd-questions@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: User questions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2013 02:23:02 -0000 Lowell Gilbert wrote: > Lowell Gilbert writes: > >> I think it's a real bug, and the test cases don't cover "extra" elements >> at all. Now I just have to figure out the right fix. > > I'm pretty sure that the fix is just to set rval on jumping to the > "extra" tag in vwalk() in src/usr.sbin/mtree/verify.c. > > But my hot water heater just exploded, so I may not look at code for a > few more days. Hello Lowell, Thank you very much. I was going crazy trying different combinations of options and script logic. I want to thank you for taking my problem seriously and taking the time to do your own test cases to verify my findings. Now that I know it's a genuine bug in mtree, I can make my plans accordingly. Any fix to the mtree utility will take some time to filter down to a regular RELEASE. Maybe 9.2 or the big jump to 10.0 by the end of 2013. I will leave it up to you the file a PR on this and follow through. Thanks again, people like you are what makes this questions list so valuable and FreeBSD such a great OS. You did outstanding work. Joe