From owner-svn-src-head@FreeBSD.ORG Wed Oct 15 15:05:35 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C06334DE; Wed, 15 Oct 2014 15:05:35 +0000 (UTC) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 7BAF42F1; Wed, 15 Oct 2014 15:05:35 +0000 (UTC) Received: from nine.des.no (smtp.des.no [194.63.250.102]) by smtp-int.des.no (Postfix) with ESMTP id 1DDF0C39B; Wed, 15 Oct 2014 15:05:33 +0000 (UTC) Received: by nine.des.no (Postfix, from userid 1001) id 4B52E4FE7; Wed, 15 Oct 2014 17:05:34 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Ed Maste Subject: Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys References: <201410101926.s9AJQRY1049602@svn.freebsd.org> <20141015030455.GC73266@FreeBSD.org> <86wq81y9fz.fsf@nine.des.no> Date: Wed, 15 Oct 2014 17:05:34 +0200 In-Reply-To: (Ed Maste's message of "Wed, 15 Oct 2014 09:10:10 -0400") Message-ID: <86siipxtj5.fsf@nine.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: src-committers , svn-src-all , "George V. Neville-Neil" , Gleb Smirnoff , Olivier =?utf-8?Q?Cochard-Labb?= =?utf-8?Q?=C3=A9?= , svn-src-head X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Oct 2014 15:05:35 -0000 Ed Maste writes: > Dag-Erling Sm=C3=B8rgrav writes: > > That's my fault, and I'm going to change it, because it's illogical. > > The function works on aligned arrays of int32s and should take a count, > > not a size. I just didn't want to delay the patch even further. > The fact that it works only on aligned 32-bit ints is a detail of this > implementation and not a requirement of murmur3 though. Absolutely. This implementation was tuned specifically for pf's use and therefore only works on aligned arrays. It is a pared-down version of a more complete implementation I wrote for cryb.to (still a WIP). DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no