Date: Wed, 04 Aug 2021 10:15:02 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 252186] [NEW PORT] audio/portmidi: Library for real time input and output of MIDI data Message-ID: <bug-252186-7788-pr1sk7kC3X@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-252186-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-252186-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252186 --- Comment #3 from Daniel Engberg <daniel.engberg.lists@pyret.net> --- Some quick notes (by no means a full review) PORTVERSION --> DISTVERSION https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-naming MASTER_SITES should use macro https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-distfiles= --> 5.4.2.1 DISTNAME should use DISTVERSION USES=3D should be sorted in alphabetical order CFLAGS and LDFLAGS should be replaced by USES=3D localbase https://docs.freebsd.org/en/books/porters-handbook/uses/#uses-localbase Is MAKE_JOBS_UNSAFE really needed? CMAKE_ARGS+=3D --> CMAKE_ARGS=3D Why is "NO_TEST=3D Yes" this needed? While I don't think there's a strict rule it would be nice avoid hosting so= urce files in tree and preferably have changes upstreamed (files/pm_sndio/pmsndi= o.c and files/pm_sndio/pmsndio.h) audio/portmidi/files/patch-pm__common_CMakeLists.txt and audio/portmidi/files/patch-pm__dylib_CMakeLists.txt seems to touch unrelated sections (APPLE)? Are portlint and/or portfmt happy? Thanks for your contribution Best regards, Daniel --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-252186-7788-pr1sk7kC3X>