From owner-freebsd-arm@FreeBSD.ORG Wed May 13 16:08:53 2015 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D7462DA1 for ; Wed, 13 May 2015 16:08:53 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A024111C3 for ; Wed, 13 May 2015 16:08:53 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t4DG8rtK076746 for ; Wed, 13 May 2015 16:08:53 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t4DG8r6c076745; Wed, 13 May 2015 16:08:53 GMT (envelope-from daemon-user) Date: Wed, 13 May 2015 16:08:53 +0000 To: freebsd-arm@freebsd.org From: "ian (Ian Lepore)" Subject: [Differential] [Accepted] D2340: Support for Alpine platform from Annapurna Labs Message-ID: <77711e70cbfad8c6f6656887e652969a@localhost.localdomain> X-Priority: 3 Thread-Topic: D2340: Support for Alpine platform from Annapurna Labs X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzFmODEzYTliMzhlZDlhOTEyM2NlYTg2YmJiIFVTdxU= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2015 16:08:53 -0000 ian accepted this revision. ian added a comment. I'm putting in an 'accept' here but want to note that I haven't carefully reviewed the entire change, partly because of time and mostly because it's so PCI-related and I don't know much about PCI. I do however want to record that my previous comments don't amount to blocking the changes. INLINE COMMENTS sys/arm/annapurna/alpine/alpine_machdep_mp.c:106 Ah, I didn't realize these were not general-purpose systems oriented towards the end user. For that case, compiling in the dtb and skipping loader(8) seems reasonable. sys/boot/fdt/dts/arm/annapurna-alpine.dts:2 I'm about 100% ignorant of linux versioning, release schedules, etc. If it's difficult to import the files into our sys/gnu area right now because of where they're at in the linux universe, then I agree that we should try to make the files we put into our sys/boot area as close as we can to what we think the final linux/official files will look like. REVISION DETAIL https://reviews.freebsd.org/D2340 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: jpa-semihalf.com, andrew, imp, ian Cc: emaste, meloun-miracle-cz, onwahe-gmail-com, freebsd-arm