From owner-cvs-all Mon Jul 23 19:59:39 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id EF9C537B403; Mon, 23 Jul 2001 19:59:24 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.4/8.11.4) with ESMTP id f6O2xNg02795; Tue, 24 Jul 2001 03:59:23 +0100 (BST) (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.4/8.11.4) with ESMTP id f6O2xLg76664; Tue, 24 Jul 2001 03:59:21 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200107240259.f6O2xLg76664@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Kris Kennaway Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@Awfulhak.org Subject: Re: cvs commit: src/usr.sbin/pppd Makefile In-Reply-To: Message from Kris Kennaway of "Mon, 23 Jul 2001 19:37:49 PDT." <200107240237.f6O2bn727783@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 24 Jul 2001 03:59:21 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG This should probably be installed as root:network with mode 4554. The network group was created for programs such as this. Mode 4550 is wrong because it breaks if /usr is mounted as an NFS filesystem with root mapped to uid -2. You could also argue that this program should not have the uid bit set and should only be run by root :*P I can't remember why I never changed this to use group network.... > kris 2001/07/23 19:37:49 PDT > > Modified files: > usr.sbin/pppd Makefile > Log: > Install this mode 4550 owned by group dialer; there is unsafe code > in the signal handlers which may pose a risk when executable by untrusted > users. > > Submitted by: Przemyslaw Frasunek > MFC After: 3 days > > Revision Changes Path > 1.23 +4 -2 src/usr.sbin/pppd/Makefile -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message