From owner-p4-projects@FreeBSD.ORG  Wed Sep 26 15:48:18 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A5CF016A524; Wed, 26 Sep 2007 15:48:18 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 29C6416A4E8
	for <perforce@freebsd.org>; Wed, 26 Sep 2007 15:48:18 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 075FC13C4A7
	for <perforce@freebsd.org>; Wed, 26 Sep 2007 15:48:17 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162]) by elvis.mu.org (Postfix) with ESMTP id 86C581A4D9A;
	Wed, 26 Sep 2007 08:48:17 -0700 (PDT)
From: John Baldwin <jhb@freebsd.org>
To: Roman Divacky <rdivacky@freebsd.org>
Date: Wed, 26 Sep 2007 10:48:10 -0400
User-Agent: KMail/1.9.7
References: <200708200201.l7K21c3v034586@repoman.freebsd.org>
	<20070820091136.GA47764@freebsd.org>
In-Reply-To: <20070820091136.GA47764@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200709261048.11221.jhb@freebsd.org>
Cc: Jesper Brix Rosenkilde <jbr@freebsd.org>,
	Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 125372 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2007 15:48:19 -0000

On Monday 20 August 2007 05:11:36 am Roman Divacky wrote:
> > +	PROC_LOCK(p);
> >  	outsysshm.pid = p->p_pid;
> > -	strncpy(outsysshm.progtitle, p->p_comm, MAXCOMLEN);
> > -	strncpy(outsysshm.proctitle, "\0", 1);
> > -	copyout((caddr_t) &outsysshm, (caddr_t) *addr, sizeof(struct sysshm)); 
> > +	copyout(&outsysshm, (vm_offset_t *)  p->p_usrsysshm, 
> > +			sizeof(struct sysshm));
> > +	PROC_UNLOCK(p);
> 
> I dont think you can copyout while holding proc lock.

Correct, but as per my earlier e-mail, the locking isn't needed anyway.

-- 
John Baldwin