Date: Sat, 24 Jul 2021 13:56:00 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: =?ISO-8859-1?Q?S=F8ren?= Schmidt <soren.schmidt@gmail.com> Cc: Free BSD <freebsd-arm@freebsd.org>, Sleep Walker <s199p.wa1k9r@gmail.com> Subject: Re: Quartz64 (RK3566) clock driver and patches. Message-ID: <20210724135600.752789eaa83309c8ab256e1e@bidouilliste.com> In-Reply-To: <FA4E6D58-1E4C-4F7A-B0E5-C231BBAFE6DF@gmail.com>
index | next in thread | previous in thread | raw e-mail
On Sat, 24 Jul 2021 13:26:07 +0200 Søren Schmidt <soren.schmidt@gmail.com> wrote: > Hi > > As promised, the clk driver I did for the RK3566 used on the Pine Quartz64 board: > > https://people.freebsd.org/~sos/Q64/ <https://people.freebsd.org/~sos/Q64/>; > > Included the buld script, kernel config and u-boot I have used to get there. That will be much easier to review on phab, or even github PR or git send-email, basically anything else that this raw diff. I've only glance at it a bit and swa this : Index: sys/arm64/rockchip/clk/rk_clk_fract.c =================================================================== --- sys/arm64/rockchip/clk/rk_clk_fract.c (revision 570) +++ sys/arm64/rockchip/clk/rk_clk_fract.c (working copy) @@ -191,8 +191,12 @@ if (sc->denominator == 0) { printf("%s: %s denominator is zero!\n", clknode_get_name(clk), __func__); +#if 0 *freq = 0; return(EINVAL); +#else + return (0); +#endif which I don't understand why it's needed. I won't look/comment at all the clocks definition in this form. > I still use the ?all inclusive? DTS and not the shiny new ?official? one (last wont boot :) ) thats for later? What does that mean ? > Next on is a driver for the RK817 PMIC used on the quartz64? > > Enjoy! > > -- > Søren Schmidt > sos@deepcore.dk / sos@freebsd.org > "So much code to hack, so little time" Cheers, -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210724135600.752789eaa83309c8ab256e1e>