From owner-svn-src-all@FreeBSD.ORG Wed Dec 8 09:14:16 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA5CD1065679; Wed, 8 Dec 2010 09:14:16 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from mail.vx.sk (mail.vx.sk [IPv6:2a01:4f8:100:1043::3]) by mx1.freebsd.org (Postfix) with ESMTP id 700438FC15; Wed, 8 Dec 2010 09:14:16 +0000 (UTC) Received: from core.vx.sk (localhost [127.0.0.1]) by mail.vx.sk (Postfix) with ESMTP id 98B3D12FF27; Wed, 8 Dec 2010 10:14:15 +0100 (CET) X-Virus-Scanned: amavisd-new at mail.vx.sk Received: from mail.vx.sk ([127.0.0.1]) by core.vx.sk (mail.vx.sk [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tTksq2XHnBEp; Wed, 8 Dec 2010 10:14:13 +0100 (CET) Received: from [10.0.3.3] (188-167-67-67.dynamic.chello.sk [188.167.67.67]) by mail.vx.sk (Postfix) with ESMTPSA id 7E8C712FF20; Wed, 8 Dec 2010 10:14:13 +0100 (CET) Message-ID: <4CFF4C65.4030607@FreeBSD.org> Date: Wed, 08 Dec 2010 10:14:13 +0100 From: Martin Matuska User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <201012080857.oB88vbH6096250@svn.freebsd.org> <20101208090433.GB1692@garage.freebsd.pl> In-Reply-To: <20101208090433.GB1692@garage.freebsd.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216291 - head/cddl/contrib/opensolaris/lib/libzfs/common X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2010 09:14:17 -0000 Here are some arguments: a) it was removed in OpenSolaris rev. 12865:08987220809a b) a root pool does not not have to be a boot pool So if we need a warning here, it should print only some general suggestion because user may attach any vdev (e.g. a file or a memory disk) to make a mirror from a root pool. And as this was removed upstream the warning should be put into perforce as well. Dňa 08.12.2010 10:04, Pawel Jakub Dawidek wrote / napísal(a): > On Wed, Dec 08, 2010 at 08:57:37AM +0000, Martin Matuska wrote: >> Author: mm >> Date: Wed Dec 8 08:57:37 2010 >> New Revision: 216291 >> URL: http://svn.freebsd.org/changeset/base/216291 >> >> Log: >> Do not print OpenSolaris hint to use (non-existing) installgrub(1) command >> if creating a mirror by attaching a new vdev to a root pool. > This warning is helpful, just incorrect. It should be changed to show > steps that are needed on FreeBSD and not just commented out. > I left it on purpose as a reminder. >