From owner-svn-src-all@freebsd.org Tue Sep 3 06:37:53 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2783CCDC3D; Tue, 3 Sep 2019 06:37:53 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46My1r0cChz3Pkb; Tue, 3 Sep 2019 06:37:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x836bgPb089835 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 3 Sep 2019 09:37:45 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x836bgPb089835 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x836bgRG089834; Tue, 3 Sep 2019 09:37:42 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 3 Sep 2019 09:37:42 +0300 From: Konstantin Belousov To: Rick Macklem Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-stable@freebsd.org" , "svn-src-stable-12@freebsd.org" Subject: Re: svn commit: r351691 - in stable/12: include/rpcsvc lib/libc/net lib/libc/rpc usr.sbin/rpc.yppasswdd usr.sbin/rpc.ypupdated usr.sbin/ypldap usr.sbin/yppush usr.sbin/ypserv Message-ID: <20190903063742.GH71821@kib.kiev.ua> References: <201909020820.x828K2D0074193@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 46My1r0cChz3Pkb X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-2.92 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[5]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.92)[-0.917,0]; IP_SCORE(0.00)[ip: (-2.73), ipnet: 2001:470::/32(-4.45), asn: 6939(-3.12), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 06:37:53 -0000 On Tue, Sep 03, 2019 at 01:42:58AM +0000, Rick Macklem wrote: > Oh, and RPC_MAXDATASIZE seems to be set at 9000. > (This is probably only a limit for UDP, but may be wired into all RPCs?) > > rick > > ________________________________________ > From: owner-src-committers@freebsd.org on behalf of Rick Macklem > Sent: Monday, September 2, 2019 9:30:45 PM > To: Konstantin Belousov; src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-stable@freebsd.org; svn-src-stable-12@freebsd.org > Subject: Re: svn commit: r351691 - in stable/12: include/rpcsvc lib/libc/net lib/libc/rpc usr.sbin/rpc.yppasswdd usr.sbin/rpc.ypupdated usr.sbin/ypldap usr.sbin/yppush usr.sbin/ypserv > > Konstantin Belousov wrote: > > > >Author: kib > >Date: Mon Sep 2 08:20:02 2019 > >New Revision: 351691 > >URL: https://svnweb.freebsd.org/changeset/base/351691 > > > >Log: > > MFC r350957: > > Increase YPMAXRECORD to 16M to be compatible with Linux. > > I am not familiar with the userland RPC libraries, but for the krpc, the size of an > RPC message is limited by the maximum sockbuf size allowed, as set by > soreserve() and limited by kern.maxsockbuf. > > You might want to look to see if the userland RPC library does the setsockopt() > { or whatever it is? } that does the soreserve()/sbreserve() for the socket in the > kernel, to see how large it gets set. My understanding is that socket buffers in fact limit the size of the single read in userspace, but userspace RPC must do and does collection of the partial reads into stream to xdr encode/decode the messages. The patch was tested in the practical settings where 1K limit was exceeded, I did not tried to determine a breaking point above it. > > I think you can get to about 2M by default? > > To be honest, I'm surprised (but maybe not amazed) that people still use > NIS/YP. Yes, they are, in quite large setups. > Just in case it matters, rick >