From owner-freebsd-arch@FreeBSD.ORG Thu Jan 14 11:47:34 2010 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 98329106566C; Thu, 14 Jan 2010 11:47:34 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail10.syd.optusnet.com.au (mail10.syd.optusnet.com.au [211.29.132.191]) by mx1.freebsd.org (Postfix) with ESMTP id 0D0788FC0C; Thu, 14 Jan 2010 11:47:33 +0000 (UTC) Received: from c122-106-161-214.carlnfd1.nsw.optusnet.com.au (c122-106-161-214.carlnfd1.nsw.optusnet.com.au [122.106.161.214]) by mail10.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id o0EBlP0U001407 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Jan 2010 22:47:27 +1100 Date: Thu, 14 Jan 2010 22:47:25 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Nikolay Denev In-Reply-To: Message-ID: <20100114222154.M62659@delplex.bde.org> References: <201001131515.08602.jhb@freebsd.org> <4B4E2ECA.90905@FreeBSD.org> <201001131633.09669.jhb@freebsd.org> <20100113.150435.650865766805848595.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: dougb@FreeBSD.org, jhb@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, freebsd-arch@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: INCLUDE_CONFIG_FILE in GENERIC X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2010 11:47:34 -0000 On Thu, 14 Jan 2010, Nikolay Denev wrote: > I just want to add a user's point of view : > To me INCLUDE_CONFIG_FILE sounds like the > whole config file will be included, > not just the output after preprocessing. It used to mean to actually include the config file. This became a broken meaning when the include directive was added in 2001, if this directory wass actually used, so that a typical config file looked like: include MOST options extra nooptions noextra This was fixed in 2007, but at the same time, for some reason stripping the comments became the default. Of course GENERIC shouldn't have verbose comments (except meta ones). Please remove any others :-). There are only 2 really annoying ones in the i386 GENERIC: - one for puc - a set of 3 separate 1-line extra ones for bpf, the first line of which essentially just repeats the expansion of the acronym `bpf' but does it with different capitalization. Bruce