From owner-freebsd-stable@FreeBSD.ORG Fri Oct 1 00:35:01 2010 Return-Path: Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1C50A1065672 for ; Fri, 1 Oct 2010 00:35:01 +0000 (UTC) (envelope-from paul@gromit.dlib.vt.edu) Received: from lennier.cc.vt.edu (lennier.cc.vt.edu [198.82.162.213]) by mx1.freebsd.org (Postfix) with ESMTP id C519E8FC12 for ; Fri, 1 Oct 2010 00:35:00 +0000 (UTC) Received: from dagger.cc.vt.edu (dagger.cc.vt.edu [198.82.163.114]) by lennier.cc.vt.edu (8.13.8/8.13.8) with ESMTP id o8UCr7cQ018814; Thu, 30 Sep 2010 08:53:07 -0400 Received: from auth3.smtp.vt.edu (EHLO auth3.smtp.vt.edu) ([198.82.161.152]) by dagger.cc.vt.edu (MOS 4.1.8-GA FastPath queued) with ESMTP id MJI86570; Thu, 30 Sep 2010 08:53:07 -0400 (EDT) Received: from gromit.tower.lib.vt.edu (gromit.tower.lib.vt.edu [128.173.51.22]) (authenticated bits=0) by auth3.smtp.vt.edu (8.13.8/8.13.8) with ESMTP id o8UCr7oK008090 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 30 Sep 2010 08:53:07 -0400 Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=us-ascii From: Paul Mather In-Reply-To: <20100930075616.GA11519@icarus.home.lan> Date: Thu, 30 Sep 2010 08:53:07 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20100930065151.GA9634@icarus.home.lan> <20100930070333.GU87427@hoeg.nl> <20100930072819.GA10678@icarus.home.lan> <4CA43C91.5040000@FreeBSD.org> <20100930075616.GA11519@icarus.home.lan> To: Jeremy Chadwick X-Mailer: Apple Mail (2.1081) X-Mirapoint-Received-SPF: 198.82.161.152 auth3.smtp.vt.edu paul@gromit.dlib.vt.edu 5 none X-Mirapoint-IP-Reputation: reputation=neutral-1, source=Fixed, refid=n/a, actions=MAILHURDLE SPF TAG X-Junkmail-Status: score=10/50, host=dagger.cc.vt.edu X-Junkmail-SD-Raw: score=unknown, refid=str=0001.0A020203.4CA48833.028E,ss=1,fgs=0, ip=0.0.0.0, so=2009-09-22 00:05:22, dmn=2009-09-10 00:05:08, mode=single engine X-Junkmail-IWF: false Cc: Ed Schouten , freebsd-stable@FreeBSD.org, Alex Dupre Subject: Re: mysqld_safe holding open a pty/tty on FreeBSD (7.x and 8.x) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Oct 2010 00:35:01 -0000 On Sep 30, 2010, at 3:56 AM, Jeremy Chadwick wrote: > The diff is pretty obvious/simple (2 line change), so the other > databases/mysqlXX-server ports can be upgraded in the same manner. >=20 > --- files/mysql-server.sh.in.orig 2010-03-27 03:24:53.000000000 = -0700 > +++ files/mysql-server.sh.in 2010-09-30 00:45:38.000000000 -0700 > @@ -35,8 +35,8 @@ > mysql_user=3D"mysql" > mysql_limits_args=3D"-e -U ${mysql_user}" > pidfile=3D"${mysql_dbdir}/`/bin/hostname`.pid" > -command=3D"%%PREFIX%%/bin/mysqld_safe" > -command_args=3D"--defaults-extra-file=3D${mysql_dbdir}/my.cnf = --user=3D${mysql_user} --datadir=3D${mysql_dbdir} --pid-file=3D${pidfile} = ${mysql_args} > /dev/null 2>&1 &" > +command=3D"/usr/sbin/daemon" > +command_args=3D"-c -f /usr/local/bin/mysqld_safe = --defaults-extra-file=3D${mysql_dbdir}/my.cnf --user=3D${mysql_user} = --datadir=3D${mysql_dbdir} --pid-file=3D${pidfile} ${mysql_args}" Shouldn't this be "-c -f %%PREFIX%%/bin/mysqld_safe ..." rather than = hard-coding /usr/local? > procname=3D"%%PREFIX%%/libexec/mysqld" > start_precmd=3D"${name}_prestart" > start_postcmd=3D"${name}_poststart" >=20 > --=20 > | Jeremy Chadwick jdc@parodius.com | > | Parodius Networking http://www.parodius.com/ | > | UNIX Systems Administrator Mountain View, CA, USA | > | Making life hard for others since 1977. PGP: 4BD6C0CB | Cheers, Paul.=