From nobody Wed Jan 7 13:50:56 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dmTvj3LNhz6MtF2 for ; Wed, 07 Jan 2026 13:50:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dmTvh6jh3z3WHK for ; Wed, 07 Jan 2026 13:50:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767793857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lbJpErCgbC9ejgfPtjjIyVWR1/mLfO4UrpIH5EGED94=; b=osUtnD9rvEcso18qr6MAp+K9l5r3bl6ibfQXjLnk3plgxw8OzOSOWsQ3gcEEGGy37jWXu8 E5dKFGA8MPoec5j5W0CXqsP8ygJxgN0g/qTnxo/x0moej0bbDM9IYzaIleW0dtjU2z9E7K MuOY4bM+Q9vTZW8D8cjphDuii5ZKvkaJVzRct92mYUsHa/Lrc4XZpD/aQFB2WlHPRJYusH 9hQAyb23tNW0jpp9t5HqZyZqFG52/cSYFqMnmHiWwA1H4f5lNwxVPm92WONb+mzzLxZo7g o1f2JWa2WIeOGoddiYU5n2hxyloXqgiZSeGOazKGpNRj8l5NSu5jhV7tJvQEsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767793857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lbJpErCgbC9ejgfPtjjIyVWR1/mLfO4UrpIH5EGED94=; b=qdV6M1X0E7DaXx+g7xKHy5UazZiyl6w5YWc+ZkbgKZi9CFTrXSXmWSSOOxh5x95TfGgP7d OFCkJ8T3w9fAePCiUCFWJRqtXBucY7JJcUuYYWjP1/1fv+WyHMIXx9Q6PX6R8gioQU2vlv H9zXgAtBgjACLxF5/hdYVnTowWNa+iHj7Vy3/e5SaFlGqwTN8ARfmOsoWYExd5IKmipm2u qXgaJMIjivICKkJT4PeXqMhC7ACiUAnl2+MO5avzpBtrHu6QxMQ8fky3XPhBEX027jz2o0 uXLH41QYtgQOnm6f3zZYEQ2aIyKHEfloeLxOVq56TTLfr9WQAKrJzGtIAC1f5A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1767793857; a=rsa-sha256; cv=none; b=lDKYWjycDRlcvTkbjduwyHOZYK+RPd+eMxx167y2lMuGB01PG8EukbsSRuoUxoFqwab4YM 6M1sB3AfexT7Ft1v5Bm09eggGcA09jjWOz61TVICBCiIMmFA7/B79rIAkLI7rAZj1tSiAF +aDNr5UKw6PDKnXnFDz4eQtl2D6mafD3qooAoI18QetDNPwSZsFiwIZ+bBGT6Qaam33XfO q0WqGVF5DVjEdAuiQvfYjYtdBWWRFCCkke6lX5f2xt2rlf6MoIeme7+6KaSCpTO+WjNuMO d5i1fPDQdP5pJ/I9H5tHWLW13Qshc7Yxi/UNmdJmjMJMn5R6moKanoQL3wHoAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dmTvh6JyrzvP9 for ; Wed, 07 Jan 2026 13:50:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3f4ca by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 07 Jan 2026 13:50:56 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 5738812be35a - stable/14 - armv8rng: Fix an inverted test in random_rndr_read_one() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 5738812be35a26cc1fa1f96d363d2c67bfb85fe0 Auto-Submitted: auto-generated Date: Wed, 07 Jan 2026 13:50:56 +0000 Message-Id: <695e64c0.3f4ca.3ed42fc7@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=5738812be35a26cc1fa1f96d363d2c67bfb85fe0 commit 5738812be35a26cc1fa1f96d363d2c67bfb85fe0 Author: Mark Johnston AuthorDate: 2025-12-18 14:17:20 +0000 Commit: Mark Johnston CommitDate: 2026-01-07 13:50:38 +0000 armv8rng: Fix an inverted test in random_rndr_read_one() If we get a random number, the NZCV is set to 0b0000. Then "cset %w1, ne" will test whether Z == 0 and set %w1 to 1 if so. More specifically, "cset %w1, ne" maps to "csinc %w1, wzr, wzr, eq", which stores 0 in %w1 when NZCV == 0b0100 and 1 otherwise. Thus, on a successful read we expect ret != 0, so the loop condition needs to be fixed. In practice this means that we would end up trying to fetch entropy up to ten times in a row. If all attempts are successful, the last will be returned, otherwise no entropy will be returned. Reported by: Kevin Day Reviewed by: andrew Fixes: 9eecef052155 ("Add an Armv8 rndr random number provider") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54259 (cherry picked from commit 93811883500b99f9f1fb4ffd6e764226d37dcfd0) --- sys/dev/random/armv8rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/random/armv8rng.c b/sys/dev/random/armv8rng.c index 524d80317681..9573c09aa77a 100644 --- a/sys/dev/random/armv8rng.c +++ b/sys/dev/random/armv8rng.c @@ -64,7 +64,7 @@ random_rndr_read_one(u_long *buf) /* 1 on success, 0 on failure */ "cset %w1, ne\n" : "=&r" (val), "=&r"(ret) :: "cc"); - } while (ret != 0 && --loop > 0); + } while (ret == 0 && --loop > 0); if (ret != 0) *buf = val;