From owner-freebsd-bugs@freebsd.org Sun Jan 8 22:43:07 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6AC6ECA6051 for ; Sun, 8 Jan 2017 22:43:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5A7561E9B for ; Sun, 8 Jan 2017 22:43:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v08Mh7pv040311 for ; Sun, 8 Jan 2017 22:43:07 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 215883] If the Setattr operation for NFSv4.1 can erroneously report EBADRPC Date: Sun, 08 Jan 2017 22:43:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2017 22:43:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D215883 Bug ID: 215883 Summary: If the Setattr operation for NFSv4.1 can erroneously report EBADRPC Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: rmacklem@FreeBSD.org Created attachment 178638 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D178638&action= =3Dedit Patch to fix the NFSv4 Setattr RPC error return. When the NFSv4 client receives a reply to a setattr where the error failure is an operation before the Setattr, the code would erroneously try to parse an attribute bitmap and fail with EBADRPC. This patch adds a check for end of RPC message to avoid this and make it reply the correct error. The main case where this would happen is in a recovery from a NFSERR_BADSESSION failure on the server, which is pretty rare. The attached 1 line patch fixes this. --=20 You are receiving this mail because: You are the assignee for the bug.=