From owner-svn-src-all@freebsd.org  Mon Aug  7 21:29:43 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2216EDC9ED7;
 Mon,  7 Aug 2017 21:29:43 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A8CBD83FDB;
 Mon,  7 Aug 2017 21:29:42 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id v77LTbCV054758
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 8 Aug 2017 00:29:38 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua v77LTbCV054758
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id v77LTbZm054757;
 Tue, 8 Aug 2017 00:29:37 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Tue, 8 Aug 2017 00:29:37 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Warner Losh <imp@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r322196 - head/sys/geom
Message-ID: <20170807212937.GJ1700@kib.kiev.ua>
References: <201708072112.v77LCSxL001381@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201708072112.v77LCSxL001381@repo.freebsd.org>
User-Agent: Mutt/1.8.3 (2017-05-23)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Aug 2017 21:29:43 -0000

On Mon, Aug 07, 2017 at 09:12:28PM +0000, Warner Losh wrote:
> +	LIST_FOREACH(gap, &pp->geom->aliases, ga_next) {
> +		error = make_dev_alias_p(MAKEDEV_CHECKNAME | MAKEDEV_WAITOK, &adev, dev,
> +		    "%s", gap->ga_alias);
> +		if (error) {
> +			printf("%s: make_dev_alias_p() failed (name=%s, error=%d)\n",
> +			    __func__, gap->ga_alias, error);
> +			continue;
> +		}
> +		adev->si_flags |= SI_UNMAPPED;
Why do you set the flag unconditionally ?

> +		adev->si_iosize_max = dev->si_iosize_max;
> +		adev->si_drv2 = dev->si_drv2;
And what are you trying to do by these initializations, including the
si_flags adjustment ?

Aliases cause creation of symlinks in the devfs populate loop, which
makes it impossible to access the alias cdevs.