From owner-freebsd-usb@FreeBSD.ORG Tue Dec 23 18:14:07 2008 Return-Path: Delivered-To: freebsd-usb@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F7201065670 for ; Tue, 23 Dec 2008 18:14:07 +0000 (UTC) (envelope-from rink@rink.nu) Received: from mx1.rink.nu (gloom.rink.nu [213.34.49.2]) by mx1.freebsd.org (Postfix) with ESMTP id E5B858FC23 for ; Tue, 23 Dec 2008 18:14:06 +0000 (UTC) (envelope-from rink@rink.nu) Received: from localhost (localhost [127.0.0.1]) by mx1.rink.nu (Postfix) with ESMTP id B480E6D43E; Tue, 23 Dec 2008 19:04:22 +0100 (CET) X-Virus-Scanned: amavisd-new at rink.nu Received: from mx1.rink.nu ([213.34.49.2]) by localhost (gloom.rink.nu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KJSsR0ECKrjv; Tue, 23 Dec 2008 19:04:16 +0100 (CET) Received: by mx1.rink.nu (Postfix, from userid 1000) id 1826A6D43D; Tue, 23 Dec 2008 19:04:16 +0100 (CET) Date: Tue, 23 Dec 2008 19:04:16 +0100 From: Rink Springer To: Ed Schouten Message-ID: <20081223180416.GB77652@rink.nu> References: <20081223175911.GZ1176@hoeg.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081223175911.GZ1176@hoeg.nl> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: freebsd-usb@FreeBSD.org Subject: Re: Giant on serial devices in USB2? X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Dec 2008 18:14:07 -0000 On Tue, Dec 23, 2008 at 06:59:11PM +0100, Ed Schouten wrote: > WHat's the exact reason USB2 still uses Giant on TTY related drivers? > Couldn't it just use the per-TTY mutex? If not, maybe it should create a > custom system-wide mutex, instead of using Giant? I think this is mostly leftover crud from the pre-TTY-MP safe days. As long as it uses the proper TTY interfaces, nothing should stop it from ditching Giant. -- Rink P.W. Springer - http://rink.nu "Chance favours the prepared mind" - Penn